Sign upLogin

TracksApp/tracks

View on GitHub
Star
app/helpers/users_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

UsersHelper#remote_delete_user calls 't('users.destroy_user')' 2 times
Open

      image_tag("blank.png", :title => t('users.destroy_user'), :class => "delete_item"),
      url_for(:controller => 'users', :action => 'destroy', :id => user.id), {
        :id => "delete_user_#{user.id}",
        :class => "delete_user_button",
        :title => t('users.destroy_user'),
Severity: Minor
Found in app/helpers/users_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

UsersHelper#remote_delete_user calls 'user.id' 2 times
Open

      url_for(:controller => 'users', :action => 'destroy', :id => user.id), {
        :id => "delete_user_#{user.id}",
Severity: Minor
Found in app/helpers/users_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

UsersHelper has no descriptive comment
Open

module UsersHelper
Severity: Minor
Found in app/helpers/users_helper.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

There are no issues that match your filters.

Category
Status