Sign upLogin

Trip-Trax/tt-stylesheet

View on GitHub
Star

Showing 7 of 7 total issues

`` has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class {
  constructor (target) {
    this._styleSheetEnabled = false;
    this._stylesheetElement = null;
    this._stylesheet = this._initializeStyleElement(target);
Severity: Minor
Found in src/tt-stylesheet.js - About 2 hrs to fix

    Function initCSS has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      initCSS () {
    const cssRules = this._stylesheet.cssRules;
    const styleElem = this._stylesheetElement;

    if (this._isArray(cssRules)) {
    Severity: Minor
    Found in src/tt-stylesheet.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Blocks are nested too deeply (4).
    Open

              if (cssRules[key] && cssRules[key].cssText) {
    Severity: Minor
    Found in src/tt-stylesheet.js by eslint

    enforce a maximum depth that blocks can be nested (max-depth)

    Many developers consider code difficult to read if blocks are nested beyond a certain depth.

    Rule Details

    This rule enforces a maximum depth that blocks can be nested to reduce code complexity.

    Options

    This rule has a number or object option:

    • "max" (default 4) enforces a maximum depth that blocks can be nested

    Deprecated: The object property maximum is deprecated; please use the object property max instead.

    max

    Examples of incorrect code for this rule with the default { "max": 4 } option:

    /*eslint max-depth: ["error", 4]*/
/*eslint-env es6*/

function foo() {
    for (;;) { // Nested 1 deep
        let val = () => (param) => { // Nested 2 deep
            if (true) { // Nested 3 deep
                if (true) { // Nested 4 deep
                    if (true) { // Nested 5 deep
                    }
                }
            }
        };
    }
}

    Examples of correct code for this rule with the default { "max": 4 } option:

    /*eslint max-depth: ["error", 4]*/
/*eslint-env es6*/

function foo() {
    for (;;) { // Nested 1 deep
        let val = () => (param) => { // Nested 2 deep
           if (true) { // Nested 3 deep
                if (true) { // Nested 4 deep
                }
            }
        };
    }
}

    Related Rules

    • [complexity](complexity.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (cssRules.hasOwnProperty(key)) {
          if (cssRules[key] && cssRules[key].cssText) {
            styleElem.appendChild(document.createTextNode(`${cssRules[key].cssText}`));
          }
        }
    Severity: Major
    Found in src/tt-stylesheet.js and 1 other location - About 1 hr to fix
    src/tt-stylesheet.js on lines 268..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          for (let i = 0; i < len; i++) {
        if (cssRules[i] && cssRules[i].cssText) {
          styleElem.appendChild(document.createTextNode(`${cssRules[i].cssText}`));
        }
      }
    Severity: Major
    Found in src/tt-stylesheet.js and 1 other location - About 1 hr to fix
    src/tt-stylesheet.js on lines 275..279

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _normalizeProperty has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      _normalizeProperty (property) {
    if (this._CACHED_PROPERTIES.hasOwnProperty(property)) {
      return this._CACHED_PROPERTIES[property];
    }
    Severity: Minor
    Found in src/tt-stylesheet.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _flattenToOneLevel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      _flattenToOneLevel( data) {
    for (let key in data) {
      const styles = data[key];

      for (let _key in styles) {
    Severity: Minor
    Found in src/tt-stylesheet.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language