Sign upLogin

Trust-Code/odoo-brasil

View on GitHub
Star
br_base/models/res_bank.py

Summary

Maintainability
A
1 hr
Test Coverage

Consider simplifying this complex logical expression.
Open

            if bank_account.bank_id:
                acc_number_format = bank_account.bank_id.acc_number_format \
                    or '%(acc_number)s'
                args = {
                    'bra_number': bank_account.bra_number or '',
Severity: Major
Found in br_base/models/res_bank.py - About 40 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @api.onchange('city_id')
    def onchange_city_id(self):
        """ Ao alterar o campo city_id copia o nome
        do município para o campo city que é o campo nativo do módulo base
        para manter a compatibilidade entre os demais módulos que usam o
    Severity: Major
    Found in br_base/models/res_bank.py and 2 other locations - About 40 mins to fix
    br_base/models/res_company.py on lines 163..171
    br_base/models/res_partner.py on lines 156..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status