Trust-Code/odoo-brasil

View on GitHub
br_cnab/models/payment_order.py

Summary

Maintainability
A
35 mins
Test Coverage

Function _compute_state has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def _compute_state(self):
        for item in self:
            if any(line.state == 'rejected' for line in item.line_ids):
                item.state = 'pending'
            elif all(line.state == 'baixa' for line in item.line_ids):
Severity: Minor
Found in br_cnab/models/payment_order.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status