Sign upLogin

Trust-Code/odoo-brasil

View on GitHub
Star
br_zip/models/br_zip.py

Summary

Maintainability
D
2 days
Test Coverage

Function set_domain has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def set_domain(self, country_id=False, state_id=False,
                   city_id=False, district=False,
                   street=False, zip_code=False):
        domain = []
        if zip_code:
Severity: Minor
Found in br_zip/models/br_zip.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_wizard has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create_wizard(self, object_name, address_id, country_id=False,
Severity: Major
Found in br_zip/models/br_zip.py - About 1 hr to fix

    Function set_result has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_result(self, zip_obj=None):
        if zip_obj:
            zip_code = zip_obj.zip
            if len(zip_code) == 8:
                zip_code = '%s-%s' % (zip_code[0:5], zip_code[5:8])
    Severity: Minor
    Found in br_zip/models/br_zip.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function seach_by_address has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def seach_by_address(self, obj, country_id=False, state_id=False,
    Severity: Minor
    Found in br_zip/models/br_zip.py - About 45 mins to fix

      Function zip_search_multi has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def zip_search_multi(self, country_id=False,
      Severity: Minor
      Found in br_zip/models/br_zip.py - About 45 mins to fix

        Function set_domain has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def set_domain(self, country_id=False, state_id=False,
        Severity: Minor
        Found in br_zip/models/br_zip.py - About 45 mins to fix

          Function zip_search_multi has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def zip_search_multi(self, country_id=False,
                         state_id=False, city_id=False,
                         district=False, street=False, zip_code=False):
        domain = self.set_domain(
            country_id=country_id,
          Severity: Minor
          Found in br_zip/models/br_zip.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if not res.get('erro', False):
                city = self.env['res.state.city'].search(
                    [('ibge_code', '=', res['ibge'][2:]),
                     ('state_id.code', '=', res['uf'])])
          Severity: Major
          Found in br_zip/models/br_zip.py and 1 other location - About 7 hrs to fix
          br_zip/models/br_zip.py on lines 133..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          for res in results:
                    city = self.env['res.state.city'].search(
                        [('ibge_code', '=', res['ibge'][2:]),
                         ('state_id.code', '=', res['uf'])])
          Severity: Major
          Found in br_zip/models/br_zip.py and 1 other location - About 7 hrs to fix
          br_zip/models/br_zip.py on lines 109..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status