TryGhost/Ghost

View on GitHub
apps/admin-x-activitypub/src/api/activitypub.test.ts

Summary

Maintainability
F
1 wk
Test Coverage

File activitypub.test.ts has 525 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {Activity, ActivityPubAPI} from './activitypub';

function NotFound() {
    return new Response(null, {
        status: 404
Severity: Major
Found in apps/admin-x-activitypub/src/api/activitypub.test.ts - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            test('Returns all the items array when the following is not empty', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 1 other location - About 6 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 380..415

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 164.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            test('Returns all the items array when the followers is not empty', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 1 other location - About 6 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 245..280

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 164.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            test('It passes the token to the following endpoint', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 2 other locations - About 6 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 39..67
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 321..349

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            test('It passes the token to the inbox endpoint', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 2 other locations - About 6 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 186..214
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 321..349

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            test('It passes the token to the followers endpoint', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 2 other locations - About 6 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 39..67
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 186..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            test('Returns an empty array when the following is empty', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 2 other locations - About 5 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 69..96
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 351..378

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            test('Returns an empty array when the inbox is empty', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 2 other locations - About 5 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 216..243
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 351..378

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            test('Returns an empty array when the followers is empty', async function () {
                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 2 other locations - About 5 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 69..96
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 216..243

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
                                token: 'fake-token'
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 1 other location - About 2 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 488..502

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                const fakeFetch = Fetch({
                    'https://auth.api/': {
                        response: JSONResponse({
                            identities: [{
                                token: 'fake-token'
    Severity: Major
    Found in apps/admin-x-activitypub/src/api/activitypub.test.ts and 1 other location - About 2 hrs to fix
    apps/admin-x-activitypub/src/api/activitypub.test.ts on lines 520..534

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status