TryGhost/Ghost

View on GitHub
apps/admin-x-design-system/src/utils/formatUrl.ts

Summary

Maintainability
C
1 day
Test Coverage

Function formatUrl has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export const formatUrl = (value: string, baseUrl?: string, nullable?: boolean) => {
    if (nullable && !value) {
        return {save: null, display: ''};
    }

Severity: Minor
Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function formatUrl has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const formatUrl = (value: string, baseUrl?: string, nullable?: boolean) => {
    if (nullable && !value) {
        return {save: null, display: ''};
    }

Severity: Major
Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

            return {save: url, display: url};
    Severity: Major
    Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return {save: url, display: url};
      Severity: Major
      Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return {save: url, display: url};
        Severity: Major
        Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return {save: url, display: displayFromBase(url, baseUrl)};
          Severity: Major
          Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return {save: url, display: url};
            Severity: Major
            Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return {save: parsedUrl.toString(), display: parsedUrl.toString()};
              Severity: Major
              Found in apps/admin-x-design-system/src/utils/formatUrl.ts - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status