TryGhost/Ghost

View on GitHub
ghost/ghost/src/nestjs/guards/admin-api-authentication.guard.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function canActivate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async canActivate(context: ExecutionContext): Promise<boolean> {
        const request = context.switchToHttp().getRequest<Request>();
        const response = context.switchToHttp().getResponse<Response>();

        const user = await this.sessionService.getUserForSession(request, response);
Severity: Minor
Found in ghost/ghost/src/nestjs/guards/admin-api-authentication.guard.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return false;
    Severity: Major
    Found in ghost/ghost/src/nestjs/guards/admin-api-authentication.guard.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return true;
      Severity: Major
      Found in ghost/ghost/src/nestjs/guards/admin-api-authentication.guard.ts - About 30 mins to fix

        Function canActivate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            async canActivate(context: ExecutionContext): Promise<boolean> {
                const request = context.switchToHttp().getRequest<Request>();
                const response = context.switchToHttp().getResponse<Response>();
        
                const user = await this.sessionService.getUserForSession(request, response);
        Severity: Minor
        Found in ghost/ghost/src/nestjs/guards/admin-api-authentication.guard.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status