Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/mail-events/src/MailEventService.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function validatePayload has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    validatePayload(payload: Payload) {
        if (payload.signature === undefined) {
            throw new errors.ValidationError({
                message: tpl(VALIDATION_MESSAGES.payloadSignatureMissing)
            });
Severity: Minor
Found in ghost/mail-events/src/MailEventService.ts - About 1 hr to fix

    Function processPayload has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async processPayload(payload: Payload) {
        if (this.labs.isSet(MailEventService.LABS_KEY) === false) {
            throw new errors.NotFoundError();
        }
    Severity: Minor
    Found in ghost/mail-events/src/MailEventService.ts - About 1 hr to fix

      Function processPayload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          async processPayload(payload: Payload) {
        if (this.labs.isSet(MailEventService.LABS_KEY) === false) {
            throw new errors.NotFoundError();
        }
      Severity: Minor
      Found in ghost/mail-events/src/MailEventService.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status