Turbasen/turbasen.py

View on GitHub

Showing 3 of 3 total issues

File apiclient.py has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from collections import UserDict
from datetime import datetime, timedelta
from json.decoder import JSONDecodeError
import json
import logging
Severity: Minor
Found in turbasen/apiclient.py - About 3 hrs to fix

    Function params_to_dotnotation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def params_to_dotnotation(params, path=''):
        """
        Transforms a dict of dicts to query parameters with dotted path as accpted by Turbasen, ex:
        {
            'foo': 'bar',
    Severity: Minor
    Found in turbasen/util.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _handle_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def _handle_response(request, method):
            """Handle responses from the API, logging warnings and raising any appropriate exception
            according to the HTTP status code"""
            try:
                response = request.json()
    Severity: Minor
    Found in turbasen/apiclient.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language