Sign upLogin

TwilightCoders/active_record-framing

View on GitHub
Star
lib/active_record/framing/default.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method build_default_frame has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def build_default_frame(base_rel = nil)
          return if abstract_class?

          if default_frame_override.nil?
            self.default_frame_override = !::ActiveRecord::Base.is_a?(method(:default_frame).owner)
Severity: Minor
Found in lib/active_record/framing/default.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_frame has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def build_frame(frames, arel_table, base_rel = nil, &block)
          cte_relation = frames.inject(base_rel.clone) do |collection, frame|
            frame = frame.respond_to?(:to_proc) ? frame : frame.method(:call)
            # Exec the frame, or grab the default_frame (by calling relation)
            frame_relation = base_rel.instance_exec(&frame)
Severity: Minor
Found in lib/active_record/framing/default.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status