Sign upLogin

TwilightCoders/active_record-framing

View on GitHub
Star
lib/active_record/framing/relation.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method build_frames has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def build_frames(manager)
        # NOTE: We cannot early exclude associations because some associations are different from their table names
        # TODO: cache known associations, (renable warning)
        assocs = klass.reflect_on_all_associations.inject(Hash.new) do |assocs, assoc|
          begin
Severity: Minor
Found in lib/active_record/framing/relation.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_arel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def build_arel(*)
        @klass.reframe_values = reframe_values
        super.tap do |ar|
          unless ignore_default_frame?
            build_frames(ar)
Severity: Minor
Found in lib/active_record/framing/relation.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status