Sign upLogin

TyrealGray/Qin.js

View on GitHub
Star

Showing 32 of 32 total issues

Avoid deeply nested control flow statements.
Open

                            if(trigger.rate && !checkChanceByTicker({seed: gameInfo.seed, time: tick}, trigger.rate)){
                                continue;
                            }
Severity: Major
Found in packages/qin.js/src/core/reactorCore/Reactor.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if (
                                trigger.triggerLimit &&
                                !eventTimeInfo.dataSet[trigger.name]
                            ) {
                                await this._store.dispatch({
    Severity: Major
    Found in packages/qin.js/src/core/reactorCore/Reactor.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (trigger.triggerLimit) {
                                await this._store.dispatch({
                                    type: RECORD_EVENT_TIME,
                                    name: trigger.name,
                                    time: tick + trigger.triggerLimit,
      Severity: Major
      Found in packages/qin.js/src/core/reactorCore/Reactor.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (!conditionInfo) {
                                continue;
                            }
        Severity: Major
        Found in packages/qin.js/src/core/reactorCore/Reactor.js - About 45 mins to fix

          Consider simplifying this complex logical expression.
          Open

                          if (
                    (onlyDirect && triggerTo?.qinId !== data.qinId)
                    || blockers.includes(triggerBy.qinId)
                    || (!isAny && !types.includes(triggerBy.type) && !triggers.includes(triggerBy.qinId))
                ) {
          Severity: Major
          Found in packages/qin.js/src/core/reactorCore/reduxCore/reducers/characterInfo.js - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                            if (
                    (onlyDirect && triggerTo?.qinId !== data.qinId)
                    || blockers.includes(triggerBy.qinId)
                    || (!isAny && !types.includes(triggerBy.type) && !triggers.includes(triggerBy.qinId))
                ) {
            Severity: Major
            Found in packages/qin.js/src/core/reactorCore/reduxCore/reducers/terrainInfo.js - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                              if (
                    (onlyDirect && triggerTo?.qinId !== data.qinId)
                    || blockers.includes(triggerBy.qinId)
                    || (!isAny && !types.includes(triggerBy.type) && !triggers.includes(triggerBy.qinId))
                ) {
              Severity: Major
              Found in packages/qin.js/src/core/reactorCore/reduxCore/reducers/npcInfo.js - About 40 mins to fix

                Function getCorrectPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    getCorrectPath(startNode: PathNode): Array<Grid> {
        const pathNodes = startNode.getNeighbors();
        const scannedPaths: Array<PathNode> = [startNode];
        const correctPath = [];
                Severity: Minor
                Found in packages/qin.js/src/core/reactorCore/gameCore/navigation/terrainNavigator.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    async start(): Promise<void> {
        try {
            await this._reactor.start();
        } catch (e) {
            console.error(e);
                Severity: Minor
                Found in packages/qin.js/src/core/QinSandbox.js and 1 other location - About 30 mins to fix
                packages/qin.js/src/Qin.js on lines 50..56

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    async start(): Promise<void> {
        try {
            await this._core.start();
        } catch (e) {
            console.error(e);
                Severity: Minor
                Found in packages/qin.js/src/Qin.js and 1 other location - About 30 mins to fix
                packages/qin.js/src/core/QinSandbox.js on lines 33..39

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function _prepareAssets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    _prepareAssets(assetsSet: Array<AnimationAssetType>) {
        let loader = PIXI.Loader.shared;
        loader.reset();

        for (let assetsData of assetsSet) {
                Severity: Minor
                Found in packages/qin-renderer.js/src/render/QinRenderer.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function dynamicReact has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const dynamicReact = (data: Object, reaction: Object, action:{type: string, triggerBy: any, triggerTo: any, stamp: { seed: string, time: number }}): void => {
    if (typeof reaction.rate !== 'undefined' && !checkChance(data, reaction, action.stamp)) {
        return;
    }
                Severity: Minor
                Found in packages/qin.js/src/core/reactorCore/processReaction.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language