UPC/mailtoticket

View on GitHub
soa/tiquets.py

Summary

Maintainability
D
1 day
Test Coverage

Function modificar_tiquet has 24 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def modificar_tiquet(
Severity: Major
Found in soa/tiquets.py - About 3 hrs to fix

    Function alta_tiquet has 19 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def alta_tiquet(
    Severity: Major
    Found in soa/tiquets.py - About 2 hrs to fix

      Function consulta_tiquets has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def consulta_tiquets(
      Severity: Major
      Found in soa/tiquets.py - About 1 hr to fix

        Function consulta_tiquets_dades has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def consulta_tiquets_dades(
        Severity: Major
        Found in soa/tiquets.py - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def consulta_tiquets(
                  self,
                  codi='',
                  estat='',
                  dataCreacioInici='',
          Severity: Major
          Found in soa/tiquets.py and 1 other location - About 3 hrs to fix
          soa/tiquets.py on lines 46..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def consulta_tiquets_dades(
                  self,
                  codi='',
                  estat='',
                  dataCreacioInici='',
          Severity: Major
          Found in soa/tiquets.py and 1 other location - About 3 hrs to fix
          soa/tiquets.py on lines 18..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status