Sign upLogin

Undev/redmine-stuff-to-do-plugin

View on GitHub
Star
app/controllers/stuff_to_do_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method get_user has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def get_user
    render_403 unless User.current.logged?

    if params[:user_id] && params[:user_id] != User.current.id.to_s
      if User.current.admin?
Severity: Minor
Found in app/controllers/stuff_to_do_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_filters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def get_filters
    return default_filters unless params[:filter]

    id = params[:filter].split('-')[-1]
Severity: Minor
Found in app/controllers/stuff_to_do_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return Project.new
Severity: Major
Found in app/controllers/stuff_to_do_controller.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return nil
    Severity: Major
    Found in app/controllers/stuff_to_do_controller.rb - About 30 mins to fix

      Method save_time_entry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def save_time_entry
    @time_entry = TimeEntry.new
    @time_entry.user = User.current
    if params[:time_entry] &&  params[:time_entry].first
      @time_entry.attributes = params[:time_entry].first
      Severity: Minor
      Found in app/controllers/stuff_to_do_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status