Sign upLogin

Undev/redmine_tagging

View on GitHub
Star
lib/tagging_plugin/tagging_hooks.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method view_layouts_base_content has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def view_layouts_base_content(context={})
        return '' if wiki_pages_inline_tags?

        return '' unless context[:controller].is_a?(WikiController)
Severity: Minor
Found in lib/tagging_plugin/tagging_hooks.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method view_layouts_base_content has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def view_layouts_base_content(context={})
        return '' if wiki_pages_inline_tags?

        return '' unless context[:controller].is_a?(WikiController)
Severity: Minor
Found in lib/tagging_plugin/tagging_hooks.rb - About 1 hr to fix

    Method controller_issues_bulk_edit_before_save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def controller_issues_bulk_edit_before_save(context={})
        return if issues_inline_tags? || !has_tags_in_params?(context[:params])

        tags  = context[:params]['issue']['tags'].to_s
        issue = context[:issue]
    Severity: Minor
    Found in lib/tagging_plugin/tagging_hooks.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method view_layouts_base_html_head has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def view_layouts_base_html_head(context = {})
        tagging_stylesheet = stylesheet_link_tag 'tagging', plugin: 'redmine_tagging'

        unless ((sidebar_tagcloud? &&
          context[:controller].is_a?(WikiController)) ||
    Severity: Minor
    Found in lib/tagging_plugin/tagging_hooks.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return tags
    Severity: Major
    Found in lib/tagging_plugin/tagging_hooks.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status