Sign upLogin

Undev/redmine_undev_git

View on GitHub
Star
app/models/hook_base.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method change_issue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def change_issue(issue)
    issue.status      = status if status
    issue.done_ratio  = done_ratio if done_ratio.present?
    issue.assigned_to = assignee(issue) if assignee(issue)
Severity: Minor
Found in app/models/hook_base.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has_changes_for_issue? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def has_changes_for_issue?(issue)
    (status && issue.status != status) ||
      (done_ratio.present? && issue.done_ratio != done_ratio) ||
      (assignee(issue) && issue.assigned_to != assignee(issue)) ||
      has_custom_field_changes_for_issue?(issue)
Severity: Minor
Found in app/models/hook_base.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method apply_for_issue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def apply_for_issue(issue, options = {}, &block)
    return unless has_changes_for_issue?(issue)

    updater = options[:user] || User.anonymous
    notes   = options[:notes] || "Changed by hook #{id}"
Severity: Minor
Found in app/models/hook_base.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status