Sign upLogin

Unleash/unleash-client-go

View on GitHub
Star
internal/strategies/gradual_rollout_user_id.go

Summary

Maintainability
A
3 hrs
Test Coverage
C
76%

Method gradualRolloutUserId.IsEnabled has 5 return statements (exceeds 4 allowed).
Open

func (s gradualRolloutUserId) IsEnabled(params map[string]interface{}, ctx *context.Context) bool {
    if ctx == nil || ctx.UserId == "" {
        return false
    }
Severity: Major
Found in internal/strategies/gradual_rollout_user_id.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package strategies

import (
    "github.com/Unleash/unleash-client-go/v3/context"
    "github.com/Unleash/unleash-client-go/v3/strategy"
    Severity: Major
    Found in internal/strategies/gradual_rollout_user_id.go and 1 other location - About 3 hrs to fix
    internal/strategies/gradual_rollout_session_id.go on lines 1..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 260.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    var groupId should be groupID
    Open

        groupId, ok := groupIdValue.(string)
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    func NewGradualRolloutUserId should be NewGradualRolloutUserID
    Open

    func NewGradualRolloutUserId() *gradualRolloutUserId {
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    var normalizedId should be normalizedID
    Open

        normalizedId := normalizedValue(ctx.UserId, groupId)
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    exported function NewGradualRolloutUserId should have comment or be unexported
    Open

    func NewGradualRolloutUserId() *gradualRolloutUserId {
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    var groupIdValue should be groupIDValue
    Open

        groupIdValue := params[strategy.ParamGroupId]
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    type gradualRolloutUserId should be gradualRolloutUserID
    Open

    type gradualRolloutUserId struct {
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    exported func NewGradualRolloutUserId returns unexported type *strategies.gradualRolloutUserId, which can be annoying to use
    Open

    func NewGradualRolloutUserId() *gradualRolloutUserId {
    Severity: Minor
    Found in internal/strategies/gradual_rollout_user_id.go by golint

    There are no issues that match your filters.

    Category
    Status