Sign upLogin

UnlyEd/next-right-now-admin

View on GitHub
Star

Showing 33 of 47 total issues

Function getValueFallback has a Cognitive Complexity of 25 (exceeds 10 allowed). Consider refactoring.
Open

export const getValueFallback = (fallbacks: Array<FallbackConfig>, defaultValue: null | any = null, missingPropStrategy: LOGGING_STRATEGY = STRATEGY_LOG_ERROR): any => {
  let value = defaultValue;
  let foundFallback;

  if (isArray(fallbacks)) {
Severity: Minor
Found in src/utils/record.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

  if ((value === NOT_FOUND || value === '' || value === '<p></p>' || (typeof value === 'object' && isEmpty(value))) && value !== 0 && value !== false) {
    return false;
  } else {
    return !!value;
  }
Severity: Major
Found in src/utils/record.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        } else {
      return {
        message: () => (`expected ${this.utils.printReceived(received)} to contain object ${this.utils.printExpected(argument)}`),
        pass: false,
      };
    Severity: Minor
    Found in src/utils/extend-jest/toContainObject.js and 1 other location - About 50 mins to fix
    src/utils/extend-jest/toContainObject.js on lines 10..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (pass) {
      return {
        message: () => (`expected ${this.utils.printReceived(received)} not to contain object ${this.utils.printExpected(argument)}`),
        pass: true,
      };
    Severity: Minor
    Found in src/utils/extend-jest/toContainObject.js and 1 other location - About 50 mins to fix
    src/utils/extend-jest/toContainObject.js on lines 15..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

              if (transform) {
            value = transform(getValue(record, key, defaultValue), { fallbacks, record, key, defaultValue });
          } else {
            value = getValue(record, key, defaultValue);
          }
    Severity: Major
    Found in src/utils/record.ts - About 45 mins to fix

      Function render has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
      Open

        render(): JSX.Element {
    const {
      Component,
      pageProps, // Type of AppPageProps
      router,
      Severity: Minor
      Found in src/pages/_app.tsx - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

      const defaultOGURL = ''; // TODO
      Severity: Minor
      Found in src/components/Head.tsx by fixme

      No licenses found for enhanced-resolve. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      enhanced-resolve@^4.1.0:
      Severity: Minor
      Found in yarn.lock by git-legal

      No licenses found for ext. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      ext@^1.1.2:
      Severity: Minor
      Found in yarn.lock by git-legal

      TODO found
      Open

      const defaultDescription = ''; // TODO
      Severity: Minor
      Found in src/components/Head.tsx by fixme

      HACK found
      Open

      import '../utils/ignoreNoisyWarningsHacks'; // HACK
      Severity: Minor
      Found in src/pages/_app.tsx by fixme

      No licenses found for url. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      url@0.11.0, url@^0.11.0:
      Severity: Minor
      Found in yarn.lock by git-legal

      No licenses found for jest-util. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      jest-util@^25.1.0:
      Severity: Minor
      Found in yarn.lock by git-legal

      No licenses found for makeerror. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      makeerror@1.0.x:
      Severity: Minor
      Found in yarn.lock by git-legal

      HACK found
      Open

          // HACK: Muting warning, fix as soon as https://github.com/amplitude/react-amplitude/issues/19 gets resolved
      Severity: Minor
      Found in src/utils/ignoreNoisyWarningsHacks.ts by fixme

      TODO found
      Open

      const defaultOGImage = ''; // TODO
      Severity: Minor
      Found in src/components/Head.tsx by fixme

      No licenses found for jest-get-type. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      jest-get-type@^22.4.3:
      Severity: Minor
      Found in yarn.lock by git-legal

      No licenses found for util. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      util@0.10.3:
      Severity: Minor
      Found in yarn.lock by git-legal

      HACK found
      Open

          // HACK: Muting warning, fix as soon as https://github.com/amplitude/react-amplitude/issues/19 gets resolved
      Severity: Minor
      Found in src/utils/ignoreNoisyWarningsHacks.ts by fixme

      No licenses found for type. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
      Open

      type@^1.0.1:
      Severity: Minor
      Found in yarn.lock by git-legal
      Severity
      Category
      Status
      Source
      Language