Sign upLogin

VIAplanner/via-timetable

View on GitHub
Star

Showing 200 of 200 total issues

Function addSectionToTimetable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const addSectionToTimetable = (sections, timetable) => {
  for (const section of sections) {
    for (const time of section.times) {
      if (section.sectionCode.length === 3) {
        const timetableSection = {
Severity: Minor
Found in src/timetable-planner/index.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      context.state.winterTimetable = {
        MONDAY: [],
        TUESDAY: [],
        WEDNESDAY: [],
        THURSDAY: [],
Severity: Minor
Found in src/store/index.js and 1 other location - About 35 mins to fix
src/store/index.js on lines 453..459

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      context.state.fallTimetable = {
        MONDAY: [],
        TUESDAY: [],
        WEDNESDAY: [],
        THURSDAY: [],
Severity: Minor
Found in src/store/index.js and 1 other location - About 35 mins to fix
src/store/index.js on lines 485..491

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

              return true;
Severity: Major
Found in src/timetable-planner/index.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                  return true;
    Severity: Major
    Found in src/timetable-planner/index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                                return true;
      Severity: Major
      Found in src/timetable-planner/index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return true;
        Severity: Major
        Found in src/timetable-planner/index.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return true;
          Severity: Major
          Found in src/timetable-planner/index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                              return true;
            Severity: Major
            Found in src/timetable-planner/index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                        return true;
              Severity: Major
              Found in src/timetable-planner/index.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return true;
                Severity: Major
                Found in src/timetable-planner/index.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                return true;
                  Severity: Major
                  Found in src/timetable-planner/index.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                  return true;
                    Severity: Major
                    Found in src/timetable-planner/index.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                              return true;
                      Severity: Major
                      Found in src/timetable-planner/index.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                      return true;
                        Severity: Major
                        Found in src/timetable-planner/index.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                                    return true;
                          Severity: Major
                          Found in src/timetable-planner/index.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                                      return true;
                            Severity: Major
                            Found in src/timetable-planner/index.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                            return true;
                              Severity: Major
                              Found in src/timetable-planner/index.js - About 30 mins to fix

                                Function selectedCourses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    selectedCourses: state => whichSemester => {
      if (whichSemester === 'F') {
        return state.fallSelectedCourses;
      } else if (whichSemester === 'S') {
        return state.winterSelectedCourses;
                                Severity: Minor
                                Found in src/store/index.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function getUniqueCourses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                const getUniqueCourses = (fallCourses, winterCourses) => {
  const uniqueCourses = {};
  const locks = [];
  const [LOCK_STRING, LOCK_TERM_INDEX, COURSE_TERM_INDEX, LEC, PRA, TUT] = [
    'Lock',
                                Severity: Minor
                                Found in src/timetable-planner/index2.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language