Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star

Showing 1,426 of 1,426 total issues

Method edit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function edit(Request $request, string $id): Response
    {
        $user = $this->userRepository->getById(
            $this->uuidFactory->fromString($id)
        );
Severity: Minor
Found in src/User/Controllers/UserViewController.php - About 1 hr to fix

    Function data has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        data: function( key, value ) {
        var i, name, data,
            elem = this[ 0 ],
            attrs = elem && elem.attributes;
    Severity: Minor
    Found in public/js/jquery.js - About 1 hr to fix

      Method handle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handle(DomainMessage $domainMessage)
    {
        $payload = $domainMessage->getPayload();

        if ($payload instanceof QuestionAsked) {
      Severity: Minor
      Found in src/Quiz/Projectors/QuestionResultProjector.php - About 1 hr to fix

        Method getTraversableDomainMessages has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getTraversableDomainMessages(
        array $types = [],
        int $firstId = null,
        int $lastId = null,
        callable $eventEntityFeedback = null,
        Severity: Minor
        Found in src/Quiz/EventStore/DoctrineEventStore.php - About 1 hr to fix

          Function handle has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function handle(DomainMessage $domainMessage)
    {
        $payload = $domainMessage->getPayload();

        if ($payload instanceof EmailRegistered) {
          Severity: Minor
          Found in src/Statistics/Projectors/UniqueParticipantProjector.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function resetFooter has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              BootstrapTable.prototype.resetFooter = function () {
        var that = this,
            data = that.getData(),
            html = [];
          Severity: Minor
          Found in public/js/bootstrap-table.js - About 1 hr to fix

            Function controller has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                      controller: function () {
            var sequences = [
              {pct: 20, label: '4'},
              {pct: 40, label: '3'},
              {pct: 60, label: '2'},
            Severity: Minor
            Found in public/js/quiz.js - About 1 hr to fix

              Function _fnInitialise has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function _fnInitialise ( settings )
    {
        var i, iLen, iAjaxStart=settings.iInitDisplayStart;
        var columns = settings.aoColumns, column;
        var features = settings.oFeatures;
              Severity: Minor
              Found in public/js/jquery.dataTables.js - About 1 hr to fix

                Function _selector_row_indexes has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    var _selector_row_indexes = function ( settings, opts )
    {
        var
            i, ien, tmp, a=[],
            displayFiltered = settings.aiDisplay,
                Severity: Minor
                Found in public/js/jquery.dataTables.js - About 1 hr to fix

                  Function _fnFilterData has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function _fnFilterData ( settings )
    {
        var columns = settings.aoColumns;
        var column;
        var i, j, ien, jen, filterData, cellData, row;
                  Severity: Minor
                  Found in public/js/jquery.dataTables.js - About 1 hr to fix

                    Method start has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function start(Request $request): Response
    {
        try {
            /** @var StartQuiz $startQuiz */
            $startQuiz = $this->serializer->deserialize(
                    Severity: Minor
                    Found in src/Quiz/Controllers/QuizController.php - About 1 hr to fix

                      Method answerQuestion has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function answerQuestion(
        \DateTimeImmutable $answeredOn,
        ?Answer $answer
    ): void {
        if ($this->askingQuestion) {
                      Severity: Minor
                      Found in src/Quiz/Aggregate/QuizAggregate.php - About 1 hr to fix

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        <?php declare(strict_types=1);

namespace VSV\GVQ_API\Mail\Models;

use VSV\GVQ_API\Common\ValueObjects\Language;
                        Severity: Major
                        Found in src/Mail/Models/Sender.php and 3 other locations - About 1 hr to fix
                        src/Company/Models/TranslatedAlias.php on lines 1..61
                        src/Partner/Models/Partner.php on lines 1..61
                        src/Report/ValueObjects/CategoryPercentage.php on lines 1..64

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 115.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        <?php declare(strict_types=1);

namespace VSV\GVQ_API\Company\Models;

use Ramsey\Uuid\UuidInterface;
                        Severity: Major
                        Found in src/Company/Models/TranslatedAlias.php and 3 other locations - About 1 hr to fix
                        src/Mail/Models/Sender.php on lines 1..64
                        src/Partner/Models/Partner.php on lines 1..61
                        src/Report/ValueObjects/CategoryPercentage.php on lines 1..64

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 115.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        <?php declare(strict_types=1);

namespace VSV\GVQ_API\Partner\Models;

use Ramsey\Uuid\UuidInterface;
                        Severity: Major
                        Found in src/Partner/Models/Partner.php and 3 other locations - About 1 hr to fix
                        src/Company/Models/TranslatedAlias.php on lines 1..61
                        src/Mail/Models/Sender.php on lines 1..64
                        src/Report/ValueObjects/CategoryPercentage.php on lines 1..64

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 115.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        <?php declare(strict_types=1);

namespace VSV\GVQ_API\Report\ValueObjects;

use VSV\GVQ_API\Common\ValueObjects\Language;
                        Severity: Major
                        Found in src/Report/ValueObjects/CategoryPercentage.php and 3 other locations - About 1 hr to fix
                        src/Company/Models/TranslatedAlias.php on lines 1..61
                        src/Mail/Models/Sender.php on lines 1..64
                        src/Partner/Models/Partner.php on lines 1..61

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 115.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function __details_events has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            var __details_events = function ( settings )
    {
        var api = new _Api( settings );
        var namespace = '.dt.DT_details';
        var drawEvent = 'draw'+namespace;
                        Severity: Minor
                        Found in public/js/jquery.dataTables.js - About 1 hr to fix

                          Function toggle has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                _proto.toggle = function toggle() {
        if (this._element.disabled || $$$1(this._element).hasClass(ClassName.DISABLED)) {
          return;
        }
                          Severity: Minor
                          Found in public/js/bootstrap.js - About 1 hr to fix

                            Function renderAnsweredQuestion has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                      function renderAnsweredQuestion (data) {
            let answerResult = 'wrong';

            for (var i = 1; i <= 3; i++) {
              view.find('[data-value="answer' + i + '"]').hide();
                            Severity: Minor
                            Found in public/js/quiz.js - About 1 hr to fix

                              Avoid excessively long variable names like $serviceWhenContestOpen. Keep variable name length under 20.
                              Open

                                  private $serviceWhenContestOpen;
                              Severity: Minor
                              Found in src/Contest/EventBusFactory.php by phpmd

                              LongVariable

                              Since: 0.2

                              Detects when a field, formal or local variable is declared with a long name.

                              Example

                              class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                              Source https://phpmd.org/rules/naming.html#longvariable

                              Severity
                              Category
                              Status
                              Source
                              Language