Showing 1,426 of 1,426 total issues
Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function handle(DomainMessage $domainMessage)
{
$payload = $domainMessage->getPayload();
if (!($payload instanceof AnsweredCorrect || $payload instanceof AnsweredInCorrect)) {
return;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCountsFromRepository has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private function getCountsFromRepository(callable $countFunction): array
{
$totalNL = 0;
$totalFR = 0;
$counts = [];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function showQuiz has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function showQuiz(ContainerInterface $container, Request $request): Response
{
$language = $request->get('language');
if ($request->query->get('channel') === 'company') {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function handle(DomainMessage $domainMessage)
{
$payload = $domainMessage->getPayload();
if ($payload instanceof QuizStarted) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
if (NULL !== $uuidStart) {- Exclude checks
Function closing brace must go on the next line following the body; found 1 blank lines before brace Open
}- Exclude checks
Expected 1 space before implements keyword; 2 found Open
class CompanyQuestionDifficultyProjector implements EventListener- Exclude checks
Expected 0 spaces between brackets of function declaration; 4 found Open
public function getAnswer2(- Exclude checks
Expected 1 space after class name; 2 found Open
class CompanyQuestionDifficultyProjector implements EventListener- Exclude checks
Empty lines are not allowed in multi-line function calls Open
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
NULL- Exclude checks
The closing parenthesis of a multi-line function declaration must be on a new line Open
NaturalNumber $answer2)- Exclude checks
The closing brace for the class must go on the next line after the body Open
}- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
parent::__construct(NULL, 200);- Exclude checks
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
return ($data instanceof Company) && in_array($format, ['json', 'csv', NULL]);- Exclude checks
Expected 0 spaces between brackets of function declaration; 4 found Open
public function getAnswer1(- Exclude checks
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{- Exclude checks
Similar blocks of code found in 10 locations. Consider refactoring. Open
$$$1.fn[NAME].noConflict = function () {
$$$1.fn[NAME] = JQUERY_NO_CONFLICT;
return Collapse._jQueryInterface;
};- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76