Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Company/Models/Company.php

Summary

Maintainability
A
45 mins
Test Coverage

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        UuidInterface $id,
        NotEmptyString $name,
        PositiveNumber $numberOfEmployees,
        TranslatedAliases $translatedAliases,
        User $user,
Severity: Minor
Found in src/Company/Models/Company.php - About 45 mins to fix

    Missing class import via use statement (line '175', column '23').
    Open

                throw new \InvalidArgumentException(
    Severity: Minor
    Found in src/Company/Models/Company.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid variables with short names like $c. Configured minimum length is 3.
    Open

            $c = clone $this;
    Severity: Minor
    Found in src/Company/Models/Company.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            UuidInterface $id,
    Severity: Minor
    Found in src/Company/Models/Company.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

        private $id;
    Severity: Minor
    Found in src/Company/Models/Company.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $c. Configured minimum length is 3.
    Open

            $c = clone $this;
    Severity: Minor
    Found in src/Company/Models/Company.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Opening brace should be on a new line
    Open

        public function withType(?string $type): Company {
    Severity: Minor
    Found in src/Company/Models/Company.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status