Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Company/Serializers/CompanyNormalizer.php

Summary

Maintainability
A
1 hr
Test Coverage

Method normalize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function normalize($company, $format = null, array $context = array()): array
    {
        $aliases = array_map(
            function (TranslatedAlias $translatedAlias) use ($format) {
                return $this->translatedAliasNormalizer->normalize(
Severity: Minor
Found in src/Company/Serializers/CompanyNormalizer.php - About 1 hr to fix

    Avoid excessively long variable names like $translatedAliasNormalizer. Keep variable name length under 20.
    Open

            TranslatedAliasNormalizer $translatedAliasNormalizer,
    Severity: Minor
    Found in src/Company/Serializers/CompanyNormalizer.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $translatedAliasNormalizer. Keep variable name length under 20.
    Open

        private $translatedAliasNormalizer;
    Severity: Minor
    Found in src/Company/Serializers/CompanyNormalizer.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
    Open

            return ($data instanceof Company) && in_array($format, ['json', 'csv', NULL]);
    Severity: Minor
    Found in src/Company/Serializers/CompanyNormalizer.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status