VSVverkeerskunde/gvq-api

View on GitHub
src/Contest/Models/TieBreaker.php

Summary

Maintainability
A
45 mins
Test Coverage

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        UuidInterface $id,
        Year $year,
        QuizChannel $channel,
        Language $language,
        NotEmptyString $question,
Severity: Minor
Found in src/Contest/Models/TieBreaker.php - About 45 mins to fix

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            UuidInterface $id,
    Severity: Minor
    Found in src/Contest/Models/TieBreaker.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

        private $id;
    Severity: Minor
    Found in src/Contest/Models/TieBreaker.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status