Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Question/Models/Answers.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '66', column '19').
Open

        throw new \RuntimeException('Did not find a correct answer!');
Severity: Minor
Found in src/Question/Models/Answers.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '36', column '20').
Open

        return new \ArrayIterator($this->answers);
Severity: Minor
Found in src/Question/Models/Answers.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Define and throw a dedicated exception instead of using a generic one.
Open

        throw new \RuntimeException('Did not find a correct answer!');
Severity: Major
Found in src/Question/Models/Answers.php by sonar-php

If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

Noncompliant Code Example

throw new Exception();  // Noncompliant

Compliant Solution

throw new InvalidArgumentException();
// or
throw new UnexpectedValueException();

See

Avoid variables with short names like $a2. Configured minimum length is 3.
Open

            function (Answer $a1, Answer $a2) {
Severity: Minor
Found in src/Question/Models/Answers.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $a1. Configured minimum length is 3.
Open

            function (Answer $a1, Answer $a2) {
Severity: Minor
Found in src/Question/Models/Answers.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status