Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Question/Repositories/Entities/QuestionEntity.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $id,
        string $language,
        int $year,
        CategoryEntity $categoryEntity,
        string $text,
Severity: Major
Found in src/Question/Repositories/Entities/QuestionEntity.php - About 1 hr to fix

    The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
    Open

        private function __construct(
        string $id,
        string $language,
        int $year,
        CategoryEntity $categoryEntity,
    Severity: Minor
    Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

    This function has 10 parameters, which is greater than the 7 authorized.
    Open

        private function __construct(
        string $id,
        string $language,
        int $year,
        CategoryEntity $categoryEntity,
    Severity: Major
    Found in src/Question/Repositories/Entities/QuestionEntity.php by sonar-php

    A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

    Noncompliant Code Example

    With a maximum number of 4 parameters:

    function doSomething($param1, $param2, $param3, $param4, $param5) {
...
}

    Compliant Solution

    function doSomething($param1, $param2, $param3, $param4) {
...
}

    The class QuestionEntity has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class QuestionEntity extends Entity
{
    /**
     * @var string
     *
    Severity: Minor
    Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid using static access to class 'VSV\GVQ_API\Question\Repositories\Entities\AnswerEntity' in method 'fromQuestion'.
    Open

                    return AnswerEntity::fromAnswer($answer);
    Severity: Minor
    Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'VSV\GVQ_API\Question\Repositories\Entities\CategoryEntity' in method 'fromQuestion'.
    Open

                CategoryEntity::fromCategory($question->getCategory()),
    Severity: Minor
    Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'toQuestion'.
    Open

                Uuid::fromString($this->getId()),
    Severity: Minor
    Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            string $id,
    Severity: Minor
    Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status