Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Statistics/Controllers/StatisticsViewController.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method statistics has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function statistics(): Response
    {
        $startedCounts = $this->statisticsService->getStartedQuizCounts();
        $finishedCounts = $this->statisticsService->getFinishedQuizCounts();
        $passedCounts = $this->statisticsService->getPassedQuizCounts();
Severity: Minor
Found in src/Statistics/Controllers/StatisticsViewController.php - About 1 hr to fix

    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Year $year,
        StatisticsService $statisticsService,
        SerializerInterface $serializer,
        ResponseFactory $responseFactory,
        TeamRepository $teamRepository,
    Severity: Major
    Found in src/Statistics/Controllers/StatisticsViewController.php - About 1 hr to fix

      This function has 9 parameters, which is greater than the 7 authorized.
      Open

          public function __construct(
        Year $year,
        StatisticsService $statisticsService,
        SerializerInterface $serializer,
        ResponseFactory $responseFactory,
      Severity: Major
      Found in src/Statistics/Controllers/StatisticsViewController.php by sonar-php

      A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

      Noncompliant Code Example

      With a maximum number of 4 parameters:

      function doSomething($param1, $param2, $param3, $param4, $param5) {
...
}

      Compliant Solution

      function doSomething($param1, $param2, $param3, $param4) {
...
}

      Avoid excessively long variable names like $passedUniqueParticipantCounts. Keep variable name length under 20.
      Open

              $passedUniqueParticipantCounts = $this->statisticsService->getPassedUniqueParticipantCounts();
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $uniqueParticipantCounts. Keep variable name length under 20.
      Open

              $uniqueParticipantCounts = $this->statisticsService->getUniqueParticipantCounts();
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $companyPlayedQuizzesRepository. Keep variable name length under 20.
      Open

          private $companyPlayedQuizzesRepository;
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $teamParticipantRepository. Keep variable name length under 20.
      Open

          private $teamParticipantRepository;
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $employeeParticipationRepository. Keep variable name length under 20.
      Open

          private $employeeParticipationRepository;
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $employeeParticipationRepository. Keep variable name length under 20.
      Open

              EmployeeParticipationRepository $employeeParticipationRepository,
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $companyPlayedQuizzesRepository. Keep variable name length under 20.
      Open

              CompanyPlayedQuizzesRepository $companyPlayedQuizzesRepository,
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $teamParticipantRepository. Keep variable name length under 20.
      Open

              TeamParticipantRepository $teamParticipantRepository
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $passedUniqueParticipantPercentage. Keep variable name length under 20.
      Open

              $passedUniqueParticipantPercentage = $this->statisticsService->getPassedUniqueParticipantPercentages();
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $detailedTopScoreAverages. Keep variable name length under 20.
      Open

              $detailedTopScoreAverages = $this->statisticsService->getDetailedTopScoreAverages();
      Severity: Minor
      Found in src/Statistics/Controllers/StatisticsViewController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status