Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method handle has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(DomainMessage $domainMessage)
    {
        $payload = $domainMessage->getPayload();
        if (!($payload instanceof AnsweredCorrect || $payload instanceof AnsweredInCorrect)) {
            return;
Severity: Minor
Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            CompanyQuestionDifficultyRepositoryFactory $questionDifficultyRepositoryFactory,
        CompanyQuestionCounterRepositoryFactory $questionAnsweredCorrectRepositoryFactory,
        CompanyQuestionCounterRepositoryFactory $questionAnsweredInCorrectRepositoryFactory,
        QuizRepository $quizRepository,
        EmployeeParticipationRepository $employeeParticipationRepository
    Severity: Minor
    Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php - About 35 mins to fix

      Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle(DomainMessage $domainMessage)
    {
        $payload = $domainMessage->getPayload();
        if (!($payload instanceof AnsweredCorrect || $payload instanceof AnsweredInCorrect)) {
            return;
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid excessively long variable names like $questionAnsweredCorrectRepositoryFactory. Keep variable name length under 20.
      Open

          private $questionAnsweredCorrectRepositoryFactory;
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $questionDifficultyRepositoryFactory. Keep variable name length under 20.
      Open

          private $questionDifficultyRepositoryFactory;
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $employeeParticipationRepository. Keep variable name length under 20.
      Open

              EmployeeParticipationRepository $employeeParticipationRepository
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $questionAnsweredInCorrectRepositoryFactory. Keep variable name length under 20.
      Open

              CompanyQuestionCounterRepositoryFactory $questionAnsweredInCorrectRepositoryFactory,
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $employeeParticipationRepository. Keep variable name length under 20.
      Open

          private $employeeParticipationRepository;
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $questionAnsweredCorrectRepositoryFactory. Keep variable name length under 20.
      Open

              CompanyQuestionCounterRepositoryFactory $questionAnsweredCorrectRepositoryFactory,
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $questionDifficultyRepositoryFactory. Keep variable name length under 20.
      Open

              CompanyQuestionDifficultyRepositoryFactory $questionDifficultyRepositoryFactory,
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $questionAnsweredInCorrectRepositoryFactory. Keep variable name length under 20.
      Open

          private $questionAnsweredInCorrectRepositoryFactory;
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Expected 1 space after class name; 2 found
      Open

      class CompanyQuestionDifficultyProjector  implements EventListener
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpcodesniffer

      Expected 1 space before implements keyword; 2 found
      Open

      class CompanyQuestionDifficultyProjector  implements EventListener
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpcodesniffer

      Expected 0 spaces after opening bracket; newline found
      Open

              if (
      Severity: Minor
      Found in src/Statistics/Projectors/CompanyQuestionDifficultyProjector.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status