Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Statistics/Repositories/Entities/EmployeeParticipationEntity.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'toEmployeeParticipation'.
Open

            Uuid::fromString($this->companyId),
Severity: Minor
Found in src/Statistics/Repositories/Entities/EmployeeParticipationEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid excessively long variable names like $employeeParticipation. Keep variable name length under 20.
Open

        EmployeeParticipation $employeeParticipation
Severity: Minor
Found in src/Statistics/Repositories/Entities/EmployeeParticipationEntity.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status