Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star
src/Statistics/Repositories/TopScoreDoctrineRepository.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getTopCompanies has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getTopCompanies(NaturalNumber $nrOfPassedEmployees): iterable
    {
        $batchSize = 10;
        $firstResult = 0;
Severity: Minor
Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php - About 1 hr to fix

    Avoid using static access to class '\VSV\GVQ_API\Statistics\Repositories\Entities\TopScoreEntity' in method 'saveWhenHigher'.
    Open

            $this->entityManager->merge(TopScoreEntity::fromTopScore($topScore));
    Severity: Minor
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "employee" 3 times.
    Open

                ->from(EmployeeParticipationEntity::class, 'employee')
    Severity: Critical
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "topScore" 5 times.
    Open

                ->select('topScore')
    Severity: Critical
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Avoid excessively long variable names like $minimalScoreToSucceed. Keep variable name length under 20.
    Open

            $minimalScoreToSucceed = 7;
    Severity: Minor
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $currentBatchItemCount. Keep variable name length under 20.
    Open

                $currentBatchItemCount = 0;
    Severity: Minor
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $succeededEmployeesCount. Keep variable name length under 20.
    Open

                    $succeededEmployeesCount = $qb->select('count(distinct employee.email) AS nrOfPassedEmployees')
    Severity: Minor
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid variables with short names like $qb. Configured minimum length is 3.
    Open

                    $qb = $this->entityManager->createQueryBuilder();
    Severity: Minor
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Line exceeds 120 characters; contains 161 characters
    Open

                        ->innerJoin(TopScoreEntity::class, 'topScore', Join::WITH, 'employee.email = topScore.email AND topScore.score >= :minimal_score_to_succeed')
    Severity: Minor
    Found in src/Statistics/Repositories/TopScoreDoctrineRepository.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status