Sign upLogin

VandyHacks/vaken

View on GitHub
Star
src/client/routes/nfc/helpers.ts

Summary

Maintainability
F
1 wk
Test Coverage
F
20%

Function createSubmitHandler has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

export const createSubmitHandler = (
    registerFunction: RegisterNfcuidWithUserMutationFn,
    markAttendedFunction: CheckInUserToEventMutationFn,
    removeFunction: RemoveUserFromEventMutationFn,
    markAttendedByNfcFunction: CheckInUserToEventByNfcMutationFn,
Severity: Minor
Found in src/client/routes/nfc/helpers.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createSubmitHandler has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

) => async (nfc: string, user: string, event: QueriedEvent, unadmit: boolean): Promise<boolean> => {
    console.log([nfc, user, event, unadmit]);
    let toastMsg = '';
    try {
        if (event.eventType === CHECK_IN_EVENT_TYPE) {
Severity: Major
Found in src/client/routes/nfc/helpers.ts - About 3 hrs to fix

Consider simplifying this complex logical expression.
Open

        if (
            word.length !== 0 &&
            !hacker.firstName.toLowerCase().includes(word) &&
            !hacker.lastName.toLowerCase().includes(word) &&
            !hacker.email.toLowerCase().includes(word) &&
Severity: Major
Found in src/client/routes/nfc/helpers.ts - About 40 mins to fix

Function generateRowClassName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

) => (arg: { index: number }) => string = (data, topUserMatch) => ({ index }) => {
    if (data[index] && data[index].id === topUserMatch) return 'selected';

    if (index < 0) return 'headerRow';
Severity: Minor
Found in src/client/routes/nfc/helpers.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const createSubmitHandler = (
    registerFunction: RegisterNfcuidWithUserMutationFn,
    markAttendedFunction: CheckInUserToEventMutationFn,
    removeFunction: RemoveUserFromEventMutationFn,
    markAttendedByNfcFunction: CheckInUserToEventByNfcMutationFn,
Severity: Major
Found in src/client/routes/nfc/helpers.ts and 1 other location - About 4 days to fix
plugins/nfc/components/helpers.ts on lines 44..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 781.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const createMatchCriteria = (searchValue: string) => (hacker: QueriedHacker): boolean => {
    let match = true;
    searchValue.split(' ').forEach(word => {
        // if no words match, return false
        if (
Severity: Major
Found in src/client/routes/nfc/helpers.ts and 1 other location - About 1 day to fix
plugins/nfc/components/helpers.ts on lines 15..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 205.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

export const generateRowClassName: (
    data: QueriedHacker[],
    topUserMatch: string
) => (arg: { index: number }) => string = (data, topUserMatch) => ({ index }) => {
    if (data[index] && data[index].id === topUserMatch) return 'selected';
Severity: Major
Found in src/client/routes/nfc/helpers.ts and 1 other location - About 4 hrs to fix
plugins/nfc/components/helpers.ts on lines 33..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status