Sign upLogin

Verites/verigraph

View on GitHub
Star
src/library/Category/TypedGraph/Adhesive.hs

Summary

Maintainability
Test Coverage

TODO found
Open

-- TODO: this function should not be here in this module
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by fixme

TODO found
Open

-- TODO: this function should not be here in this module
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by fixme

Avoid restricted qualification
Open

import qualified Data.Graphs                        as G
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by hlint

Found

import qualified Data.Graphs as G

Perhaps

import qualified Data.Graphs as Graph

Applying this change:

  • may break the code

Use .
Open

      b = addCollapsedEdges $ addCollapsedNodes $ addDanglingNodes init
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by hlint

Found

addCollapsedEdges $ addCollapsedNodes $ addDanglingNodes init

Perhaps

addCollapsedEdges . addCollapsedNodes $ addDanglingNodes init

Redundant bracket
Open

          (\(e,src,tgt) b ->
            (createEdgeOnDomain e src tgt (edgeTypesInA e) e
              (createNodeOnDomain tgt (nodeTypesInA tgt) tgt
                (createNodeOnDomain src (nodeTypesInA src) src b)
              )
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by hlint

Found

\ (e, src, tgt) b ->
  (createEdgeOnDomain e src tgt (edgeTypesInA e) e
     (createNodeOnDomain tgt (nodeTypesInA tgt) tgt
        (createNodeOnDomain src (nodeTypesInA src) src b)))

Perhaps

\ (e, src, tgt) b ->
  createEdgeOnDomain e src tgt (edgeTypesInA e) e
    (createNodeOnDomain tgt (nodeTypesInA tgt) tgt
       (createNodeOnDomain src (nodeTypesInA src) src b))

Move guards forward
Open

            edgesFromA = [(edgeId e, u, v) |
                           e <- orphanTypedEdges m,
                           u <- nodeIds (domain edgesL'),
                           v <- nodeIds (domain edgesL'),
                           sourceId e == applyNodeIdUnsafe edgesL' u,
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by hlint

Found

[(edgeId e, u, v) | e <- orphanTypedEdges m,
 u <- nodeIds (domain edgesL'), v <- nodeIds (domain edgesL'),
 sourceId e == applyNodeIdUnsafe edgesL' u,
 targetId e == applyNodeIdUnsafe edgesL' v]

Perhaps

[(edgeId e, u, v) | e <- orphanTypedEdges m,
 u <- nodeIds (domain edgesL'),
 sourceId e == applyNodeIdUnsafe edgesL' u,
 v <- nodeIds (domain edgesL'),
 targetId e == applyNodeIdUnsafe edgesL' v]

There are no issues that match your filters.

Category
Status