Sign upLogin

Verkehrsministerium/kraftfahrstrasse

View on GitHub
Star

Showing 47 of 47 total issues

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in src/generic/Callee.ts - About 30 mins to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        try {
      await this.sender(msg);
    } catch (err) {
      this.regs.Remove(requestID, err);
      throw err;
    Severity: Major
    Found in src/generic/Callee.ts and 4 other locations - About 30 mins to fix
    src/generic/Callee.ts on lines 300..305
    src/generic/Publisher.ts on lines 85..90
    src/generic/Subscriber.ts on lines 163..168
    src/generic/Subscriber.ts on lines 239..244

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

          return [true, true, ''];
    Severity: Major
    Found in src/util/map.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in src/generic/Caller.ts - About 30 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            try {
      await this.sender(msg);
    } catch (err) {
      this.subs.Remove(requestID, err);
      throw err;
        Severity: Major
        Found in src/generic/Subscriber.ts and 4 other locations - About 30 mins to fix
        src/generic/Callee.ts on lines 200..205
        src/generic/Callee.ts on lines 300..305
        src/generic/Publisher.ts on lines 85..90
        src/generic/Subscriber.ts on lines 239..244

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            try {
      await this.sender(msg);
    } catch (err) {
      this.publications.Remove(requestID, err);
      throw err;
        Severity: Major
        Found in src/generic/Publisher.ts and 4 other locations - About 30 mins to fix
        src/generic/Callee.ts on lines 200..205
        src/generic/Callee.ts on lines 300..305
        src/generic/Subscriber.ts on lines 163..168
        src/generic/Subscriber.ts on lines 239..244

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function processSessionMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          private processSessionMessage(msg: WampMessage): void {
    if (!this.transport) {
      return;
    }
    this.state.update([EMessageDirection.RECEIVED, msg[0]]);
        Severity: Minor
        Found in src/generic/Connection.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language