Sign upLogin

Verkehrsministerium/kraftfahrstrasse

View on GitHub
Star
src/generic/Subscriber.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function Subscribe has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public async Subscribe<
    A extends WampList,
    K extends WampDict
    >(topic: WampURI, handler: EventHandler<A, K>, options?: SubscribeOptions): Promise<ISubscription> {
    if (this.closed) {
Severity: Minor
Found in src/generic/Subscriber.ts - About 1 hr to fix

    Function onMessage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected onMessage(msg: WampMessage): boolean {
    let [handled, success, error] = this.subs.Handle(msg);
    if (handled) {
      if (!success) {
        this.violator(error);
    Severity: Minor
    Found in src/generic/Subscriber.ts - About 1 hr to fix

      Function onMessage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        protected onMessage(msg: WampMessage): boolean {
    let [handled, success, error] = this.subs.Handle(msg);
    if (handled) {
      if (!success) {
        this.violator(error);
      Severity: Minor
      Found in src/generic/Subscriber.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public static GetFeatures(): WampDict {
    return {
      subscriber: {
        features: {
          publisher_identification: true,
      Severity: Major
      Found in src/generic/Subscriber.ts and 1 other location - About 1 hr to fix
      src/generic/Caller.ts on lines 11..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
    await this.sender(msg);
    } catch (err) {
      this.unsubs.Remove(requestID, err);
      throw err;
      Severity: Major
      Found in src/generic/Subscriber.ts and 4 other locations - About 30 mins to fix
      src/generic/Callee.ts on lines 200..205
      src/generic/Callee.ts on lines 300..305
      src/generic/Publisher.ts on lines 85..90
      src/generic/Subscriber.ts on lines 163..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
      await this.sender(msg);
    } catch (err) {
      this.subs.Remove(requestID, err);
      throw err;
      Severity: Major
      Found in src/generic/Subscriber.ts and 4 other locations - About 30 mins to fix
      src/generic/Callee.ts on lines 200..205
      src/generic/Callee.ts on lines 300..305
      src/generic/Publisher.ts on lines 85..90
      src/generic/Subscriber.ts on lines 239..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status