Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/models/country_report.rb

Summary

Maintainability
D
2 days
Test Coverage

File country_report.rb has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'httparty'

class CountryReport
  include HTTParty
  include Concerns::Cached
Severity: Minor
Found in app/models/country_report.rb - About 3 hrs to fix

    Method get_province_vals_for has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_province_vals_for(data, indicator)

    values = data.select do |t|
      t["boundary_code"] == @use_boundary &&
        t["indicator_id"] == indicator &&
    Severity: Minor
    Found in app/models/country_report.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_country_data_for has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def parse_country_data_for(data, indicator, period=:reference)
    result = {}
    start_year = period == :reference ? @reference_start_year : @monitor_start_year
    end_year = period == :reference ? @reference_end_year : @monitor_end_year
    Severity: Minor
    Found in app/models/country_report.rb - About 1 hr to fix

      Method get_province_vals_for has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_province_vals_for(data, indicator)

    values = data.select do |t|
      t["boundary_code"] == @use_boundary &&
        t["indicator_id"] == indicator &&
      Severity: Minor
      Found in app/models/country_report.rb - About 1 hr to fix

        Method parse_country_data_for has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse_country_data_for(data, indicator, period=:reference)
    result = {}
    start_year = period == :reference ? @reference_start_year : @monitor_start_year
    end_year = period == :reference ? @reference_end_year : @monitor_end_year
        Severity: Minor
        Found in app/models/country_report.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method prepare_response has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def prepare_response results
    return {} if !results || results.empty?
    response = {}
    response[:iso] = @iso
    response[:country] = results.first["country"]
        Severity: Minor
        Found in app/models/country_report.rb - About 1 hr to fix

          Method emission_factors_from has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def emission_factors_from data
    response = {}

    total = 0
    val = data.select do |t|
          Severity: Minor
          Found in app/models/country_report.rb - About 1 hr to fix

            Method emission_factors_from has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def emission_factors_from data
    response = {}

    total = 0
    val = data.select do |t|
            Severity: Minor
            Found in app/models/country_report.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Consider simplifying this complex logical expression.
            Open

                below = if @below
              val = data.select do |t|
                t["boundary_code"] == @use_boundary &&
                  t["indicator_id"] == BELOW_C_DENSITY &&
                  t["sub_nat_id"] == nil &&
            Severity: Major
            Found in app/models/country_report.rb - About 40 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    values.each do |t|
        exclude = excluded_vals.select{|p| p["year"] == t["year"]}.first
        if exclude && exclude["value"]
          t["value"] = t["value"] - exclude["value"]
        end
              Severity: Minor
              Found in app/models/country_report.rb and 1 other location - About 35 mins to fix
              app/models/country_report.rb on lines 235..239

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      vals.each do |t|
          exclude = excluded_vals.select{|p| p["year"] == t["year"]}.first
          if exclude && exclude["value"]
            t["value"] = t["value"] - exclude["value"]
          end
              Severity: Minor
              Found in app/models/country_report.rb and 1 other location - About 35 mins to fix
              app/models/country_report.rb on lines 182..186

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  val = data.select do |t|
      t["boundary_code"] == @use_boundary &&
        t["indicator_id"] == TOTAL_C_DENSITY &&
        t["sub_nat_id"] == nil &&
        t["year"] = 2000
              Severity: Minor
              Found in app/models/country_report.rb and 2 other locations - About 20 mins to fix
              app/models/country_report.rb on lines 280..285
              app/models/country_report.rb on lines 298..303

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 28.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                            val = data.select do |t|
                t["boundary_code"] == @use_boundary &&
                  t["indicator_id"] == BELOW_C_DENSITY &&
                  t["sub_nat_id"] == nil &&
                  t["year"] = 2000
              Severity: Minor
              Found in app/models/country_report.rb and 2 other locations - About 20 mins to fix
              app/models/country_report.rb on lines 280..285
              app/models/country_report.rb on lines 288..293

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 28.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  val = data.select do |t|
      t["boundary_code"] == @use_boundary &&
        t["indicator_id"] == ABOVE_C_DENSITY &&
        t["sub_nat_id"] == nil &&
        t["year"] = 2000
              Severity: Minor
              Found in app/models/country_report.rb and 2 other locations - About 20 mins to fix
              app/models/country_report.rb on lines 288..293
              app/models/country_report.rb on lines 298..303

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 28.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status