Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/models/data_portal_download.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method data_to_headers_and_rows has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def data_to_headers_and_rows(data)
    rows = []
    if @pivot
      core_headers = data.first.keys.reject{ |k| ['year', 'value'].include? k }
      years = Set.new
Severity: Minor
Found in app/models/data_portal_download.rb - About 1 hr to fix

    Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize options
    @country_codes = options[:country_codes].present? ? options[:country_codes].first.split(",") : []
    @jurisdiction_ids = options[:jurisdiction_ids] || []
    @area_ids = options[:area_ids] || []
    @years = options[:years] || []
    Severity: Minor
    Found in app/models/data_portal_download.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method where_clause has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def where_clause
    where = <<-SQL
      WHERE indicators.indicator_id IN (#{@indicator_ids.join(",")})
    SQL
    Severity: Minor
    Found in app/models/data_portal_download.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method data_to_headers_and_rows has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def data_to_headers_and_rows(data)
    rows = []
    if @pivot
      core_headers = data.first.keys.reject{ |k| ['year', 'value'].include? k }
      years = Set.new
    Severity: Minor
    Found in app/models/data_portal_download.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status