Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star

Showing 1,213 of 1,213 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    BubbleChart.prototype.create_nodes = function() {
      this.data.forEach(
        (function(_this) {
          return function(d) {
            if (parseFloat(d.Average).toFixed(3) > 0.003) {
Severity: Major
Found in app/assets/javascripts/embed/views/pantropical/vis.js and 1 other location - About 2 days to fix
app/assets/javascripts/countries/views/pantropical/vis.js on lines 200..247

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 424.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    BubbleChart.prototype.display_group_all = function() {
      this.force
        .gravity(this.layout_gravity)
        .charge(this.charge)
        .friction(0.9)
Severity: Major
Found in app/assets/javascripts/embed/views/pantropical/vis.js and 1 other location - About 2 days to fix
app/assets/javascripts/countries/views/pantropical/vis.js on lines 323..367

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 407.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    BubbleChart.prototype.display_group_all = function() {
      this.force
        .gravity(this.layout_gravity)
        .charge(this.charge)
        .friction(0.9)
Severity: Major
Found in app/assets/javascripts/countries/views/pantropical/vis.js and 1 other location - About 2 days to fix
app/assets/javascripts/embed/views/pantropical/vis.js on lines 323..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 407.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    StackedChart.prototype._drawAxes = function() {
      var self = this;
      var tickSizeX = $(window).width() > 1025 ? 1 : 2;
      var tickFormatY = this.unit != 'percentage' ? '.2s' : '.2f';
      this.xAxis = d3.svg
Severity: Major
Found in app/assets/javascripts/widgets/indicators/stacked/StackedChart.js and 1 other location - About 2 days to fix
app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 114..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 370.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    LineChart.prototype._drawAxes = function() {
      var self = this;
      var tickSizeX = $(window).width() > 1025 ? 1 : 2;
      var tickFormatY = this.unit != 'percentage' ? '.2s' : '.2f';
      this.xAxis = d3.svg
Severity: Major
Found in app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js and 1 other location - About 2 days to fix
app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 149..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 370.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File vis.js has 840 lines of code (exceeds 250 allowed). Consider refactoring.
Open

function CustomTooltip(tooltipId, width) {
  var tooltipId = tooltipId;
  $('#vis').append("<div class='tooltip' id='" + tooltipId + "'></div>");

  if (width) {
Severity: Major
Found in app/assets/javascripts/countries/views/pantropical/vis.js - About 2 days to fix

    File vis.js has 827 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    function CustomTooltip(tooltipId, width) {
  var tooltipId = tooltipId;
  $('#vis').append("<div class='tooltip' id='" + tooltipId + "'></div>");

  if (width) {
    Severity: Major
    Found in app/assets/javascripts/embed/views/pantropical/vis.js - About 1 day to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            _player: function() {
        if (this.$play_pause.hasClass('is-playing')) {
          window.setTimeout(
            function() {
              this.progression += 100 / this.ticks;
      Severity: Major
      Found in app/assets/javascripts/countries/views/CountryPantropicalView.js and 1 other location - About 1 day to fix
      app/assets/javascripts/embed/views/pantropical/PantropicalView.js on lines 290..327

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 349.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            _player: function() {
        if (this.$play_pause.hasClass('is-playing')) {
          window.setTimeout(
            function() {
              this.progression += 100 / this.ticks;
      Severity: Major
      Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
      app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 283..320

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 349.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File HistoricalTrendChartView.js has 818 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      define(
  [
    'backbone',
    'handlebars',
    'underscore',
      Severity: Major
      Found in app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js - About 1 day to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              if (sorted_index < col_count) {
        y_position = 150;
      } else if (sorted_index < 2 * col_count) {
        y_position = 300;
      } else if (sorted_index < 3 * col_count) {
        Severity: Major
        Found in app/assets/javascripts/countries/views/pantropical/vis.js and 1 other location - About 1 day to fix
        app/assets/javascripts/embed/views/pantropical/vis.js on lines 795..825

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 340.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              if (sorted_index < col_count) {
        y_position = 150;
      } else if (sorted_index < 2 * col_count) {
        y_position = 300;
      } else if (sorted_index < 3 * col_count) {
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/vis.js and 1 other location - About 1 day to fix
        app/assets/javascripts/countries/views/pantropical/vis.js on lines 796..826

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 340.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              _changeYear: function(ev) {
        var action = ev.currentTarget.dataset.action;
        var $parent = ev.currentTarget.parentNode;
        var $selector = $parent.querySelector('.js-year-selector');
        var options = $selector.options;
        Severity: Major
        Found in app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/insights/views/InsightsGladAlertsView.js on lines 371..410

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 339.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            _changeYear: function(ev) {
      var action = ev.currentTarget.dataset.action;
      var $parent = ev.currentTarget.parentNode;
      var $selector = $parent.querySelector('.js-year-selector');
      var options = $selector.options;
        Severity: Major
        Found in app/assets/javascripts/insights/views/InsightsGladAlertsView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsView.js on lines 433..471

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 339.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File InsightsGladAlertsChartView.js has 798 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        define(
  [
    'backbone',
    'handlebars',
    'underscore',
        Severity: Major
        Found in app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js - About 1 day to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                _hideYears: function(elementID) {
        var $opositeSelector;
        var selectedYear;
        var condition;
        var value;
          Severity: Major
          Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
          app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 146..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 332.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                _hideYears: function(elementID) {
        var $opositeSelector;
        var selectedYear;
        var condition;
        var value;
          Severity: Major
          Found in app/assets/javascripts/countries/views/CountryPantropicalView.js and 1 other location - About 1 day to fix
          app/assets/javascripts/embed/views/pantropical/PantropicalView.js on lines 133..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 332.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                _setAxisScale: function() {
        var average = _.findWhere(this.defaults.labels, { slug: 'average' });
        var barsContentWidth =
          average.width * this.cWidthGrid / 100 - this.defaults.barMargin * 2;
          Severity: Major
          Found in app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js and 1 other location - About 1 day to fix
          app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 174..203

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 321.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                _setAxisScale: function() {
        var average = _.findWhere(this.defaults.labels, { slug: 'average' });
        var barsContentWidth =
          average.width * this.cWidthGrid / 100 - this.defaults.barMargin * 2;
          Severity: Major
          Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 1 other location - About 1 day to fix
          app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 220..249

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 321.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          define(['Class', 'mps', 'moment', 'amplify', 'underscore'], function(
  Class,
  mps,
  moment,
  amplify,
          Severity: Major
          Found in app/assets/javascripts/compare/services/DataService.js and 1 other location - About 1 day to fix
          app/assets/javascripts/map/services/DataService.js on lines 5..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 316.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language