Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star

Showing 1,213 of 1,213 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      (this.width = this.parentWidth - this.sizing.left - this.sizing.right),
        (this.height =
          this.parentHeight - this.sizing.top - this.sizing.bottom);
Severity: Major
Found in app/assets/javascripts/widgets/indicators/stacked/StackedChart.js and 2 other locations - About 2 hrs to fix
app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 37..39
app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 32..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      objToSlug: function(obj, join) {
        var arr_temp = [];
        arr_temp[0] = obj['iso'];
        arr_temp[1] = obj['jurisdiction'];
        arr_temp[2] = obj['area'];
Severity: Major
Found in app/assets/javascripts/compare/presenters/CompareGridPresenter.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/embed/presenters/EmbedCountryPresenter.js on lines 112..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      objToSlug: function(obj, join) {
        var arr_temp = [];
        arr_temp[0] = obj['iso'];
        arr_temp[1] = obj['jurisdiction'];
        arr_temp[2] = obj['area'];
Severity: Major
Found in app/assets/javascripts/embed/presenters/EmbedCountryPresenter.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/compare/presenters/CompareGridPresenter.js on lines 274..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      var line = d3.svg
        .line()
        .x(function(d) {
          return x(d.date);
        })
Severity: Major
Found in app/assets/javascripts/countries/views/pantropical/PantropicalTotalEmissionsView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/embed/views/pantropical/PantropicalTotalEmissionsView.js on lines 112..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      (this.width = this.parentWidth - this.sizing.left - this.sizing.right),
        (this.height =
          this.parentHeight - this.sizing.top - this.sizing.bottom);
Severity: Major
Found in app/assets/javascripts/widgets/indicators/line/LineChart.js and 2 other locations - About 2 hrs to fix
app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 32..34
app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 32..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      var line = d3.svg
        .line()
        .x(function(d) {
          return x(d.date);
        })
Severity: Major
Found in app/assets/javascripts/embed/views/pantropical/PantropicalTotalEmissionsView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/views/pantropical/PantropicalTotalEmissionsView.js on lines 112..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        barGroup
          .append('rect')
          .attr('class', 'bar monitor')
          .attr('height', this.defaults.barHeight)
          .attr(
Severity: Major
Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 533..548

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    CustomInfowindow.prototype.remove = function() {
      // Check if the overlay was on the map and needs to be removed.
      if (this.div_) {
        this.div_.parentNode.removeChild(this.div_);
        this.div_ = null;
Severity: Major
Found in app/assets/javascripts/map/views/layers/CustomInfowindow.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/map/views/layers/CustomMarker.js on lines 67..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  CustomMarker.prototype.remove = function() {
    // Check if the overlay was on the map and needs to be removed.
    if (this.div_) {
      this.div_.parentNode.removeChild(this.div_);
      this.div_ = null;
Severity: Major
Found in app/assets/javascripts/map/views/layers/CustomMarker.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/map/views/layers/CustomInfowindow.js on lines 112..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function draw has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    CustomInfowindow.prototype.draw = function() {
      // Check if the div has been created.
      var div = this.div_,
        closeButton,
        analyseButton;
Severity: Major
Found in app/assets/javascripts/map/views/layers/CustomInfowindow.js - About 2 hrs to fix

    Function onDataSourceChange has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          onDataSourceChange: function(selection) {
        var years = [];
        var trhesAllowed = false;

        if (selection && selection.length) {
    Severity: Major
    Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 2 hrs to fix

      Function getCountries has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            getCountries: function(options) {
        var filters = options || {
          geo: false
        };
        return new Promise(
      Severity: Major
      Found in app/assets/javascripts/services/CountryService.js - About 2 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              calculateOffsets: function() {
        this.offsetTop = this.$offsetTop.offset().top;
        this.offsetBottom = this.$offsetBottom.offset().top - this.$el.height();
      },
        Severity: Major
        Found in app/assets/javascripts/countries/views/show/FixedHeaderView.js and 2 other locations - About 2 hrs to fix
        app/assets/javascripts/compare/views/index/CompareFixedHeaderView.js on lines 46..49
        app/assets/javascripts/compare/views/index/CompareSwitcherView.js on lines 106..109

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              _calculateOffsets: function() {
        this.offsetTop = this.$offsetTop.offset().top;
        this.offsetBottom = this.$offsetBottom.offset().top - this.$el.height();
      },
        Severity: Major
        Found in app/assets/javascripts/compare/views/index/CompareSwitcherView.js and 2 other locations - About 2 hrs to fix
        app/assets/javascripts/compare/views/index/CompareFixedHeaderView.js on lines 46..49
        app/assets/javascripts/countries/views/show/FixedHeaderView.js on lines 66..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              between: function(num, a, b, inclusive) {
        var min = Math.min(a, b),
          max = Math.max(a, b);
        return inclusive ? num >= min && num <= max : num > min && num < max;
      },
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/multiline/MultiLineChartIndicator.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/line/LineChartIndicator.js on lines 145..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              calculateOffsets: function() {
        this.offsetTop = this.$offsetTop.offset().top;
        this.offsetBottom = this.$offsetBottom.offset().top - this.$el.height();
      },
        Severity: Major
        Found in app/assets/javascripts/compare/views/index/CompareFixedHeaderView.js and 2 other locations - About 2 hrs to fix
        app/assets/javascripts/compare/views/index/CompareSwitcherView.js on lines 106..109
        app/assets/javascripts/countries/views/show/FixedHeaderView.js on lines 66..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              between: function(num, a, b, inclusive) {
        var min = Math.min(a, b),
          max = Math.max(a, b);
        return inclusive ? num >= min && num <= max : num > min && num < max;
      },
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/line/LineChartIndicator.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/multiline/MultiLineChartIndicator.js on lines 254..258

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      case 'subnational':
                if (this.status.get('widgetsActive').length == 0) {
                  this.status.set('jurisdictionsIds', []);
                }
        Severity: Major
        Found in app/assets/javascripts/countries/presenters/show/CountryWidgetsModalPresenter.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/countries/presenters/show/CountryWidgetsModalPresenter.js on lines 141..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      case 'areas-interest':
                if (this.status.get('widgetsActive').length == 0) {
                  this.status.set('areasIds', []);
                }
        Severity: Major
        Found in app/assets/javascripts/countries/presenters/show/CountryWidgetsModalPresenter.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/countries/presenters/show/CountryWidgetsModalPresenter.js on lines 132..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function get_coordinates has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            BubbleChart.prototype.get_coordinates = function(sorted_index) {
      var dist_x = 85;
      var dist_y = 55;
      var offset_x = 75;
      var offset_y = 50;
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/vis.js - About 2 hrs to fix
          Severity
          Category
          Status
          Source
          Language