Vizzuality/gfw-climate

View on GitHub

Showing 1,213 of 1,213 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (
          !params.params.primary_forest &&
          this._hasPrimaryForest(params.iso) &&
          this._isDefaultPrimaryForest(params.iso)
        ) {
Severity: Major
Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/countries/views/CountryReportView.js on lines 100..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (
          !params.params.exclude_plantations &&
          this._hasPlantations(params.iso) &&
          this._isDefaultExcludePlantations(params.iso)
        ) {
Severity: Major
Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/countries/views/CountryReportView.js on lines 93..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (
              !hoverCarbonLoss &&
              !hoverMenuLogin &&
              !hoverCarbonGains &&
              !hoverCarbonDensity &&
Severity: Major
Found in app/assets/javascripts/map/views/MapView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/MapView.js on lines 625..630

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

define(
  [
    'abstract/layer/CartoDBLayerClass',
    'text!map/cartocss/concesiones_peruTypes.cartocss'
  ],
app/assets/javascripts/map/views/layers/WWFLayer.js on lines 6..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getTile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getTile: function(coord, zoom, ownerDocument) {
      var tileId = this._getTileId(coord.x, coord.y, zoom);
      // Delete all tiles from others zooms;
      var tilesKeys = Object.keys(this.tiles);

Severity: Minor
Found in app/assets/javascripts/abstract/layer/CanvasLayerClass.js - About 1 hr to fix

    Function _onPlaceGo has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          _onPlaceGo: function(place) {
            var layerOptions = {};
            this._setMapOptions(
              _.pick(
                place.params,
    Severity: Minor
    Found in app/assets/javascripts/map/presenters/MapPresenter.js - About 1 hr to fix

      Function result_select has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              (Chosen.prototype.result_select = function(a) {
                var b, c;
                return this.result_highlight
                  ? ((b = this.result_highlight),
                    this.result_clear_highlight(),
      Severity: Minor
      Found in app/assets/javascripts/chosen.jquery.min.js - About 1 hr to fix

        Function setTab has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              setTab: function() {
                var tabs = this.presenter.status.get('tabs');
                var position = tabs ? tabs.position : 0;
                // UI
                this.$tablink.removeClass('-selected');
        Severity: Minor
        Found in app/assets/javascripts/widgets/views/WidgetView.js - About 1 hr to fix

          Function setTooltip has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              LineChart.prototype.setTooltip = function(x0, is_reflect) {
                var self = this;
                var datum = self.data;
                var info = [];
                var x0 = x0;

            Method parse_country_data_for has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              def parse_country_data_for(data, indicator, period=:reference)
                result = {}
                start_year = period == :reference ? @reference_start_year : @monitor_start_year
                end_year = period == :reference ? @reference_end_year : @monitor_end_year
            
            
            Severity: Minor
            Found in app/models/country_report.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _drawSemiDashedLine has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  _drawSemiDashedLine: function() {
                    var _this = this;
                    var allYData = _.pluck(this.chartData, this.dataColumns.semiDashed.y);
                    var allXData = _.pluck(this.chartData, this.dataColumns.semiDashed.x);
                    var label = '2001 - 2014 Average:';

              Function subscribeAlerts has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    subscribeAlerts: function() {
                      var email = this.$el.find('#areaEmail').val();
                      var topic = 'Subscribe to alerts';
              
                      var data = {
              Severity: Minor
              Found in app/assets/javascripts/map/views/tabs/SubscribeView.js - About 1 hr to fix

                Similar blocks of code found in 12 locations. Consider refactoring.
                Open

                        enquire.register(
                          'screen and (min-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                          {
                            match: _.bind(function() {
                              this.mobile = false;
                Severity: Major
                Found in app/assets/javascripts/map/views/tabs/BasemapsView.js and 11 other locations - About 1 hr to fix
                app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
                app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
                app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
                app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
                app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
                app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
                app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
                app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
                app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
                app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
                app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 12 locations. Consider refactoring.
                Open

                        enquire.register(
                          'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                          {
                            match: _.bind(function() {
                              this.mobile = true;
                app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
                app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
                app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
                app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
                app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
                app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
                app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
                app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
                app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
                app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
                app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function _drawProvinces has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      _drawProvinces: function() {
                        var provinceGroup = this.svg.select('.province');
                        var provincesContent = this.svg
                          .append('g')
                          .attr(

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                          enquire.register(
                            'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                            {
                              match: _.bind(function() {
                                this.mobile = true;
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
                  app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
                  app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
                  app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
                  app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                          enquire.register(
                            'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                            {
                              match: _.bind(function() {
                                this.mobile = true;
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
                  app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
                  app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
                  app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              _.bind(function() {
                                $tab.find('.source_header').addClass('active');
                                $tab.find('.source_body').show(0);
                                this.calculateOffsets();
                              }, this)
                  Severity: Major
                  Found in app/assets/javascripts/views/SidebarNavView.js and 1 other location - About 1 hr to fix
                  app/assets/javascripts/views/SidebarNavView.js on lines 241..245

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                          enquire.register(
                            'screen and (min-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                            {
                              match: _.bind(function() {
                                this.mobile = false;
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
                  app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
                  app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
                  app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                      enquire.register(
                        'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                        {
                          match: _.bind(function() {
                            this.mobile = true;
                  Severity: Major
                  Found in app/assets/javascripts/widgets/indicators/pie/PieChart.js and 11 other locations - About 1 hr to fix
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
                  app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
                  app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
                  app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
                  app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
                  app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
                  app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
                  app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language