Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/authorization/formodule/scenario-ownership.interceptor.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function isComparisonRequestAuthorized has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  private async isComparisonRequestAuthorized(
    request: Request,
    additionalChecks: ScenarioCheckWhiteListOptions,
  ): Promise<boolean> {
    const baseScenarioId: string = request.query.baseScenarioId as string;
Severity: Minor
Found in api/src/modules/authorization/formodule/scenario-ownership.interceptor.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function intercept has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async intercept(
    context: ExecutionContext,
    next: CallHandler,
  ): Promise<Observable<any>> {
    if (this.scenarioAcl.isUserAdmin()) {
Severity: Minor
Found in api/src/modules/authorization/formodule/scenario-ownership.interceptor.ts - About 1 hr to fix

    Function isComparisonRequestAuthorized has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async isComparisonRequestAuthorized(
    request: Request,
    additionalChecks: ScenarioCheckWhiteListOptions,
  ): Promise<boolean> {
    const baseScenarioId: string = request.query.baseScenarioId as string;
    Severity: Minor
    Found in api/src/modules/authorization/formodule/scenario-ownership.interceptor.ts - About 1 hr to fix

      Function intercept has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        async intercept(
    context: ExecutionContext,
    next: CallHandler,
  ): Promise<Observable<any>> {
    if (this.scenarioAcl.isUserAdmin()) {
      Severity: Minor
      Found in api/src/modules/authorization/formodule/scenario-ownership.interceptor.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status