Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/impact/impact.repository.ts

Summary

Maintainability
D
2 days
Test Coverage

File impact.repository.ts has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Brackets,
  EntityManager,
  SelectQueryBuilder,
  WhereExpressionBuilder,
Severity: Minor
Found in api/src/modules/impact/impact.repository.ts - About 3 hrs to fix

    Function createBasicSelectQuery has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private createBasicSelectQuery(
    impactDataDto: GetActualVsScenarioImpactTableDto | BaseImpactTableDto,
  ): SelectQueryBuilder<SourcingRecord> {
    const basicSelectQuery: SelectQueryBuilder<SourcingRecord> =
      this.entityManager
    Severity: Major
    Found in api/src/modules/impact/impact.repository.ts - About 2 hrs to fix

      Function addEntityFiltersToQuery has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private addEntityFiltersToQuery(
    selectQueryBuilder: SelectQueryBuilder<SourcingRecord>,
    impactDataDto: GetActualVsScenarioImpactTableDto | GetImpactTableDto,
  ): SelectQueryBuilder<SourcingRecord> {
    if (impactDataDto.materialIds) {
      Severity: Minor
      Found in api/src/modules/impact/impact.repository.ts - About 1 hr to fix

        Function addGroupAndOrderByToQuery has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private addGroupAndOrderByToQuery(
    selectQueryBuilder: SelectQueryBuilder<SourcingRecord>,
    impactDataDto: GetActualVsScenarioImpactTableDto | BaseImpactTableDto,
  ): SelectQueryBuilder<SourcingRecord> {
    switch (impactDataDto.groupBy) {
        Severity: Minor
        Found in api/src/modules/impact/impact.repository.ts - About 1 hr to fix

          Function getDataForActualVsScenarioImpactTable has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async getDataForActualVsScenarioImpactTable(
    getActualVsScenarioImpactTable: GetActualVsScenarioImpactTableDto,
  ): Promise<ImpactTableData[]> {
    const impactDataQueryBuilder: SelectQueryBuilder<SourcingRecord> =
      this.createBasicSelectQuery(getActualVsScenarioImpactTable);
          Severity: Minor
          Found in api/src/modules/impact/impact.repository.ts - About 1 hr to fix

            Function handleSourceDataSelect has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private handleSourceDataSelect(
    queryBuilder: SelectQueryBuilder<SourcingRecord>,
    dto: GetImpactTableDto,
  ): SelectQueryBuilder<SourcingRecord> {
    if (dto.scenarioId) {
            Severity: Minor
            Found in api/src/modules/impact/impact.repository.ts - About 1 hr to fix

              Function addEntityFiltersToQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                private addEntityFiltersToQuery(
    selectQueryBuilder: SelectQueryBuilder<SourcingRecord>,
    impactDataDto: GetActualVsScenarioImpactTableDto | GetImpactTableDto,
  ): SelectQueryBuilder<SourcingRecord> {
    if (impactDataDto.materialIds) {
              Severity: Minor
              Found in api/src/modules/impact/impact.repository.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (dto.scenarioId) {
      queryBuilder
        .leftJoin(
          ScenarioIntervention,
          'scenarioIntervention',
              Severity: Major
              Found in api/src/modules/impact/impact.repository.ts and 1 other location - About 4 hrs to fix
              api/src/modules/h3-data/h3-data.repository.ts on lines 357..381

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 122.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  impactDataQueryBuilder.andWhere(
      new Brackets((qb: WhereExpressionBuilder) => {
        qb.where('sourcingLocation.scenarioInterventionId is null').orWhere(
          new Brackets((qbInterv: WhereExpressionBuilder) => {
            qbInterv
              Severity: Major
              Found in api/src/modules/impact/impact.repository.ts and 1 other location - About 3 hrs to fix
              api/src/utils/base.query-builder.ts on lines 72..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status