Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/import-data/eudr/eudr.dto-processor.service.ts

Summary

Maintainability
C
1 day
Test Coverage

Function save has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async save(
    importData: EudrInputShape[],
    sourcingLocationGroupId?: string,
  ): Promise<{
    sourcingLocations: SourcingLocation[];
Severity: Major
Found in api/src/modules/import-data/eudr/eudr.dto-processor.service.ts - About 3 hrs to fix

    Function save has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      async save(
    importData: EudrInputShape[],
    sourcingLocationGroupId?: string,
  ): Promise<{
    sourcingLocations: SourcingLocation[];
    Severity: Minor
    Found in api/src/modules/import-data/eudr/eudr.dto-processor.service.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getAdminRegionByIntersection has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async getAdminRegionByIntersection(
    queryRunner: QueryRunner,
    geometry: string,
  ): Promise<string> {
    this.logger.log(`Intersecting EUDR geometry...`);
    Severity: Minor
    Found in api/src/modules/import-data/eudr/eudr.dto-processor.service.ts - About 1 hr to fix

      Function validateCleanData has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async validateCleanData(nonEmptyData: SourcingData[]): Promise<void> {
    const excelErrors: {
      line: number;
      column: string;
      errors: { [type: string]: string } | undefined;
      Severity: Minor
      Found in api/src/modules/import-data/eudr/eudr.dto-processor.service.ts - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export interface SourcingData extends CreateSourcingLocationDto {
  sourcingRecords: SourcingRecord[] | { year: number; tonnage: number }[];
  geoRegionId?: string;
  adminRegionId?: string;
}
        Severity: Major
        Found in api/src/modules/import-data/eudr/eudr.dto-processor.service.ts and 1 other location - About 1 hr to fix
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 19..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status