Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/import-data/sourcing-data/dto-processor.service.ts

Summary

Maintainability
F
3 days
Test Coverage
A
99%

File dto-processor.service.ts has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Injectable, Logger } from '@nestjs/common';
import { CreateMaterialDto } from 'modules/materials/dto/create.material.dto';
import { CreateBusinessUnitDto } from 'modules/business-units/dto/create.business-unit.dto';
import { CreateSupplierDto } from 'modules/suppliers/dto/create.supplier.dto';
import { CreateAdminRegionDto } from 'modules/admin-regions/dto/create.admin-region.dto';
Severity: Minor
Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts - About 3 hrs to fix

    Function parseSourcingDataFromSheet has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      async parseSourcingDataFromSheet(customData: WorkSheet[]): Promise<{
    sourcingData: SourcingData[];
  }> {
    this.logger.debug(`Cleaning ${customData.length} custom data rows`);
    const sourcingData: SourcingData[] = [];
    Severity: Minor
    Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseSourcingDataFromSheet has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async parseSourcingDataFromSheet(customData: WorkSheet[]): Promise<{
    sourcingData: SourcingData[];
  }> {
    this.logger.debug(`Cleaning ${customData.length} custom data rows`);
    const sourcingData: SourcingData[] = [];
    Severity: Minor
    Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts - About 1 hr to fix

      Function createSourcingLocationDTOFromData has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async createSourcingLocationDTOFromData(
    sourcingLocationData: Record<string, any>,
    sourcingLocationGroupId?: string,
  ): Promise<CreateSourcingLocationDto> {
    const sourcingLocationDto: CreateSourcingLocationDto =
      Severity: Minor
      Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts - About 1 hr to fix

        Function createSourcingLocationDTOFromData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          private async createSourcingLocationDTOFromData(
    sourcingLocationData: Record<string, any>,
    sourcingLocationGroupId?: string,
  ): Promise<CreateSourcingLocationDto> {
    const sourcingLocationDto: CreateSourcingLocationDto =
        Severity: Minor
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private async createBusinessUnitDTOFromData(
    businessUnitData: Record<string, any>,
  ): Promise<CreateBusinessUnitDto> {
    const businessUnitDto: CreateBusinessUnitDto = new CreateBusinessUnitDto();
    businessUnitDto.name = businessUnitData.name;
        Severity: Major
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts and 2 other locations - About 3 hrs to fix
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 298..306
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 308..316

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private async crateSuppliersDTOFromData(
    supplierData: Record<string, any>,
  ): Promise<CreateSupplierDto> {
    const suppliersDto: CreateSupplierDto = new CreateSupplierDto();
    suppliersDto.name = supplierData.name;
        Severity: Major
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts and 2 other locations - About 3 hrs to fix
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 288..296
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 308..316

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private async createAdminRegionDTOFromData(
    adminRegionData: Record<string, any>,
  ): Promise<CreateAdminRegionDto> {
    const adminRegionDto: CreateAdminRegionDto = new CreateAdminRegionDto();
    adminRegionDto.name = adminRegionData.name;
        Severity: Major
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts and 2 other locations - About 3 hrs to fix
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 288..296
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 298..306

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          async createBusinessUnitDtos(
    importData: Record<string, any>[],
  ): Promise<CreateBusinessUnitDto[]> {
    const businessUnitDtos: CreateBusinessUnitDto[] = [];
    for (const importRow of importData) {
        Severity: Major
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts and 1 other location - About 2 hrs to fix
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 177..185

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          async createMaterialDtos(
    importData: Record<string, any>[],
  ): Promise<CreateMaterialDto[]> {
    const materialList: CreateMaterialDto[] = [];
    for (const importRow of importData) {
        Severity: Major
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts and 1 other location - About 2 hrs to fix
        api/src/modules/import-data/sourcing-data/dto-processor.service.ts on lines 192..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export interface SourcingData extends CreateSourcingLocationDto {
  sourcingRecords: SourcingRecord[] | { year: number; tonnage: number }[];
  geoRegionId?: string;
  adminRegionId?: string;
}
        Severity: Major
        Found in api/src/modules/import-data/sourcing-data/dto-processor.service.ts and 1 other location - About 1 hr to fix
        api/src/modules/import-data/eudr/eudr.dto-processor.service.ts on lines 29..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status