Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/import-data/sourcing-data/sourcing-data-import.service.ts

Summary

Maintainability
C
7 hrs
Test Coverage
A
92%

Function importSourcingData has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async importSourcingData(filePath: string, taskId: string): Promise<any> {
    this.logger.log(`Starting import process`);
    await this.fileService.isFilePresentInFs(filePath);
    try {
      const parsedXLSXDataset: SourcingRecordsSheets =
Severity: Major
Found in api/src/modules/import-data/sourcing-data/sourcing-data-import.service.ts - About 3 hrs to fix

    Function relateSourcingDataWithOrganizationalEntities has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      async relateSourcingDataWithOrganizationalEntities(
    suppliers: Supplier[],
    businessUnits: Record<string, any>[],
    materials: Material[],
    sourcingData: SourcingData[],
    Severity: Minor
    Found in api/src/modules/import-data/sourcing-data/sourcing-data-import.service.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function relateSourcingDataWithOrganizationalEntities has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async relateSourcingDataWithOrganizationalEntities(
    suppliers: Supplier[],
    businessUnits: Record<string, any>[],
    materials: Material[],
    sourcingData: SourcingData[],
    Severity: Minor
    Found in api/src/modules/import-data/sourcing-data/sourcing-data-import.service.ts - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status