Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/scenario-interventions/scenario-interventions.service.ts

Summary

Maintainability
C
1 day
Test Coverage
A
96%

File scenario-interventions.service.ts has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  BadRequestException,
  Injectable,
  NotFoundException,
} from '@nestjs/common';
Severity: Minor
Found in api/src/modules/scenario-interventions/scenario-interventions.service.ts - About 2 hrs to fix

    Function createScenarioIntervention has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async createScenarioIntervention(
    dto: CreateScenarioInterventionDto,
  ): Promise<Partial<ScenarioIntervention>> {
    // Validate new location. If it's validated, get the geolocated info. If not, throw an exception
    Severity: Major
    Found in api/src/modules/scenario-interventions/scenario-interventions.service.ts - About 2 hrs to fix

      Function createNewSourcingLocationsForIntervention has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async createNewSourcingLocationsForIntervention(
    sourcingLocations: SourcingLocation[],
    canceledOrReplacing: SOURCING_LOCATION_TYPE_BY_INTERVENTION,
  ): Promise<SourcingLocation[]> {
    const cancelledSourcingLocations: SourcingLocation[] = [];
      Severity: Minor
      Found in api/src/modules/scenario-interventions/scenario-interventions.service.ts - About 1 hr to fix

        Function serializerConfig has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          get serializerConfig(): JSONAPISerializerConfig<ScenarioIntervention> {
    return {
      attributes: [
        'title',
        'description',
        Severity: Minor
        Found in api/src/modules/scenario-interventions/scenario-interventions.service.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            constructor(
    protected readonly scenarioInterventionRepository: ScenarioInterventionRepository,
    protected readonly interventionBuilder: InterventionBuilder,
    protected readonly geoCodingService: GeoCodingAbstractClass,
    protected readonly sourcingLocationsService: SourcingLocationsService,
          Severity: Major
          Found in api/src/modules/scenario-interventions/scenario-interventions.service.ts and 1 other location - About 1 hr to fix
          api/src/modules/geo-regions/geo-regions.service.ts on lines 31..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                return this.geoCodingService.geoCodeSourcingLocation({
        locationAdminRegionInput: dto.newLocationAdminRegionInput,
        locationLongitude: dto.newLocationLongitude,
        locationLatitude: dto.newLocationLatitude,
        locationAddressInput: dto.newLocationAddressInput,
          Severity: Major
          Found in api/src/modules/scenario-interventions/scenario-interventions.service.ts and 1 other location - About 1 hr to fix
          api/src/modules/h3-data/h3-data.repository.ts on lines 523..530

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status