Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/sourcing-locations/sourcing-locations.service.ts

Summary

Maintainability
C
1 day
Test Coverage
B
84%

Function findSourcingLocationsWithSourcingRecords has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async findSourcingLocationsWithSourcingRecords(
    createInterventionDto: CreateScenarioInterventionDto,
  ): Promise<SourcingLocation[]> {
    const queryBuilder: SelectQueryBuilder<SourcingLocation> =
      this.sourcingLocationRepository
Severity: Major
Found in api/src/modules/sourcing-locations/sourcing-locations.service.ts - About 2 hrs to fix

    Function getLocationTypes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async getLocationTypes(
    locationTypesOptions: GetLocationTypesDto,
  ): Promise<LocationTypesDto> {
    if (locationTypesOptions.supported) {
      return this.getAllSupportedLocationTypes({
    Severity: Minor
    Found in api/src/modules/sourcing-locations/sourcing-locations.service.ts - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        constructor(
    protected readonly sourcingLocationRepository: SourcingLocationRepository,
    @Inject(forwardRef(() => AdminRegionsService))
    protected readonly adminRegionService: AdminRegionsService,
    @Inject(forwardRef(() => BusinessUnitsService))
      Severity: Major
      Found in api/src/modules/sourcing-locations/sourcing-locations.service.ts and 3 other locations - About 5 hrs to fix
      api/src/modules/admin-regions/admin-regions.service.ts on lines 37..53
      api/src/modules/materials/materials.service.ts on lines 39..55
      api/src/modules/suppliers/suppliers.service.ts on lines 31..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 138.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        async findByGeoRegionId(
    geoRegionId: string,
  ): Promise<SourcingLocation | null> {
    return this.sourcingLocationRepository.findOne({ where: { geoRegionId } });
  }
      Severity: Major
      Found in api/src/modules/sourcing-locations/sourcing-locations.service.ts and 1 other location - About 1 hr to fix
      api/src/modules/h3-data/h3-data.service.ts on lines 71..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status