Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
api/src/modules/sourcing-records/sourcing-records.controller.ts

Summary

Maintainability
D
1 day
Test Coverage
A
100%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @ApiOperation({ description: 'Find sourcing record by id' })
  @ApiOkResponse({ type: SourcingRecord })
  @ApiNotFoundResponse({ description: 'Sourcing record not found' })
  @JSONAPISingleEntityQueryParams()
  @Get(':id')
Severity: Major
Found in api/src/modules/sourcing-records/sourcing-records.controller.ts and 1 other location - About 5 hrs to fix
api/src/modules/sourcing-locations/sourcing-locations.controller.ts on lines 156..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @ApiOperation({ description: 'Updates a sourcing record' })
  @ApiOkResponse({ type: SourcingRecord })
  @ApiNotFoundResponse({ description: 'Sourcing record not found' })
  @UseInterceptors(SetUserInterceptor)
  @Patch(':id')
Severity: Major
Found in api/src/modules/sourcing-records/sourcing-records.controller.ts and 1 other location - About 5 hrs to fix
api/src/modules/sourcing-location-groups/sourcing-location-groups.controller.ts on lines 109..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 137.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  @ApiOperation({ description: 'Deletes a sourcing record' })
  @ApiOkResponse()
  @ApiNotFoundResponse({ description: 'Sourcing record not found' })
  @Delete(':id')
  async delete(@Param('id') id: string): Promise<void> {
Severity: Major
Found in api/src/modules/sourcing-records/sourcing-records.controller.ts and 6 other locations - About 2 hrs to fix
api/src/modules/scenario-interventions/scenario-interventions.controller.ts on lines 124..130
api/src/modules/sourcing-location-groups/sourcing-location-groups.controller.ts on lines 123..129
api/src/modules/suppliers/suppliers.controller.ts on lines 155..161
api/src/modules/unit-conversions/unit-conversions.controller.ts on lines 110..116
api/src/modules/units/units.controller.ts on lines 108..114
api/src/modules/url-params/url-params.controller.ts on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status