Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
client/src/pages/analysis/chart.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function ChartPage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ChartPage: NextPageWithLayout = () => {
  const dispatch = useAppDispatch();
  const [syncedIndicators] = useSyncIndicators();

  const { data, isLoading } = useIndicators(undefined, {
Severity: Minor
Found in client/src/pages/analysis/chart.tsx - About 1 hr to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export const getServerSideProps: GetServerSideProps = async ({ req, res, query }) => {
  try {
    const tasks = await tasksSSR({ req, res });
    if (tasks && tasks[0]?.attributes.status === 'processing') {
      return {
    Severity: Major
    Found in client/src/pages/analysis/chart.tsx and 4 other locations - About 1 day to fix
    client/src/pages/analysis/map.tsx on lines 44..72
    client/src/pages/analysis/table.tsx on lines 40..68
    client/src/pages/data/scenarios/index.tsx on lines 262..289
    client/src/pages/data/targets.tsx on lines 101..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 237.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    ChartPage.Layout = function getLayout(page: ReactElement) {
  return (
    <ApplicationLayout>
      <AnalysisLayout>{page}</AnalysisLayout>
    </ApplicationLayout>
    Severity: Major
    Found in client/src/pages/analysis/chart.tsx and 2 other locations - About 55 mins to fix
    client/src/pages/analysis/map.tsx on lines 36..42
    client/src/pages/analysis/table.tsx on lines 32..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status