Sign upLogin

Vizzuality/landgriffon

View on GitHub
Star
cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts

Summary

Maintainability
D
2 days
Test Coverage

File FlowMapLayer.ts has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @ts-nocheck
/*
 * Copyright 2022 FlowmapBlue
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
Severity: Minor
Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 4 hrs to fix

    Function renderLayers has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      renderLayers(): Array<any> {
    const layers = [];
    if (this.state?.layersData) {
      const { layersData, highlightedObject } = this.state;
      const { circleAttributes, lineAttributes } = layersData || {};
    Severity: Major
    Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 2 hrs to fix

      Function _getFlowLayerPickingInfo has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        private async _getFlowLayerPickingInfo(
    info: Record<string, any>,
  ): Promise<FlowLayerPickingInfo<L, F> | undefined> {
    const { index, sourceLayer } = info;
    const { dataProvider, accessors } = this.state || {};
      Severity: Minor
      Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function renderLayers has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        renderLayers(): Array<any> {
    const layers = [];
    if (this.state?.layersData) {
      const { layersData, highlightedObject } = this.state;
      const { circleAttributes, lineAttributes } = layersData || {};
      Severity: Minor
      Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _getFlowLayerPickingInfo has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async _getFlowLayerPickingInfo(
    info: Record<string, any>,
  ): Promise<FlowLayerPickingInfo<L, F> | undefined> {
    const { index, sourceLayer } = info;
    const { dataProvider, accessors } = this.state || {};
      Severity: Major
      Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 2 hrs to fix

        Function _getHighlightedObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          private _getHighlightedObject(info: Record<string, any>): HighlightedObject | undefined {
    const { index, sourceLayer } = info;
    if (index < 0) return undefined;
    if (sourceLayer instanceof FlowLinesLayer || sourceLayer instanceof AnimatedFlowLinesLayer) {
      const { lineAttributes } = this.state?.layersData || {};
        Severity: Minor
        Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateState has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          updateState({ oldProps, props, changeFlags }: Record<string, any>): void {
    const { dataProvider, highlightedObject } = this.state || {};
    if (!dataProvider) {
      return;
    }
        Severity: Minor
        Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            const {
      locationTotalsEnabled,
      adaptiveScalesEnabled,
      animationEnabled,
      clusteringEnabled,
        Severity: Minor
        Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts and 1 other location - About 50 mins to fix
        cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts on lines 210..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            return {
      locationTotalsEnabled,
      adaptiveScalesEnabled,
      animationEnabled,
      clusteringEnabled,
        Severity: Minor
        Found in cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts and 1 other location - About 50 mins to fix
        cookie-traceability/src/lib/flowmap/layers/FlowMapLayer.ts on lines 198..209

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status